Unreviewed patches

Zdenek Dvorak rakdver@atrey.karlin.mff.cuni.cz
Wed Jul 30 17:33:00 GMT 2003


Hello,

> On Mon, Jul 21, 2003 at 09:27:31PM +0200, Zdenek Dvorak wrote:
> > http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01174.html
> > 	-- patch for optimization/10080
> 
> This part of variable_initial_value looks broken.
> 
> + 	  /* If we know that the initial value is indeed in range of
> + 	     the inner mode, record the fact even in case the value itself
> + 	     is useless.  */
> + 	  if ((GET_CODE (val) == SIGN_EXTEND
> + 	       || GET_CODE (val) == ZERO_EXTEND)
> + 	      && GET_MODE (XEXP (val, 0)) == inner_mode)
> + 	    ret = gen_rtx_fmt_e (GET_CODE (val),
> + 				 GET_MODE (var),
> + 				 gen_rtx_fmt_ei (SUBREG,
> + 						 inner_mode,
> + 						 var, 0));
> 
> I think at minimum you should be using simplify_gen_subreg
> et all.
>
> I notice to that you *do* do the correct thing later
> in count_loop_iterations.

Why is this incorrect? I just want to record here that the register var
is equal to extend (subreg (var)).

Zdenek



More information about the Gcc-patches mailing list