[PATCH] Symbol Separation - Take 2

[Andreas Jaeger]

Devang Patel <dpatel@apple.com> writes:

> This patch is same as previous patch. Only difference is in
> documentation.
>
> OK to commit ?

No, please clean up the prototypes for ISO C90.

> [...]
> + void
> + cb_restore_write_symbols ()

This has to be:
cb_restore_write_symbols (void)

> [...]
> + void
> + cb_end_symbol_repository ()

Same here

> [...]
> diff -Idpatel.pbxuser -c -3 -p -r1.26 c-objc-common.c
> *** c-objc-common.c	8 Jul 2003 19:44:17 -0000	1.26
> --- c-objc-common.c	14 Jul 2003 17:47:02 -0000
> *************** Software Foundation, 59 Temple Place - S
> *** 38,43 ****
> --- 38,45 ----
>   #include "langhooks.h"
>   #include "target.h"
>   #include "cgraph.h"
> + #include "c-pragma.h" /* For parse_in */
> + #include "debug.h"    /* For debug_hooks */

We do not use such comments in GCC.  Please remove them.
  
>   static bool c_tree_printer (output_buffer *, text_info *);
>   static tree inline_forbidden_p (tree *, int *, void *);
> *************** finish_cdtor (tree body)
> *** 350,355 ****
> --- 352,368 ----
>     finish_function (0, 0);
>   }
>   
> + 
> + /* Write context information in .cinfo file.
> +    Use PCH routines directly.  */
> + void
> + c_common_write_context ()

Another prototype problem.  Please fix all of them, I'll not point out
the others.
> + /* Indicate state of context info processing.
> +    Context info processing shares code with PCH, but it does not need
> +    everything PCH does. Use this context info states to exclude not
> +    required stuff.  */
> + enum cpp_cinfo_state
> +   {
> +     CINFO_NONE,
> +     CINFO_FOUND,  /* Context information found */

Please make comments as full sentences ending with a "." and two
spaces.

> +     CINFO_VALID,  /* Context information is valid */
> +     CINFO_READ,   /* Reading context information */
> +     CINFO_WRITE   /* Writing context information */
> +   };
> + 
>   /* A cpp_reader encapsulates the "state" of a pre-processor run.
>      Applying cpp_get_token repeatedly yields a stream of pre-processor
>      tokens.  Usually, there is only one cpp_reader object active.  */
> *************** struct cpp_reader
> *** 447,452 ****
> --- 460,469 ----
>     /* A saved list of the defined macros, for dependency checking
>        of precompiled headers.  */
>     struct cpp_savedstate *savedstate;
> + 
> +   /* State of context information read/write operation.  */
> +   enum cpp_cinfo_state cinfo_state;
> +   
>   };
>   
>   /* Character classes.  Based on the more primitive macros in safe-ctype.h.
> *************** wrap_help (const char *help, const char 
> *** 1551,1557 ****
>   	    }
>   	}
>   
> !       printf( "  %-*.*s %.*s\n", col_width, item_width, item, len, help);
>         item_width = 0;
>         while (help[len] == ' ')
>   	len++;
> --- 1554,1560 ----
>   	    }
>   	}
>   
> !       printf( "  %-*.*s %.*s\n", col_width, (int)item_width, item, len, help);
>         item_width = 0;
>         while (help[len] == ' ')
>   	len++;

Are you sure that this part of the diff is needed for your patch?  It
looks unrelated.

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20030714/d39ab801/attachment.sig>