[Patch] Allow options.[ch] to be possibly regenerated after reconfigure --enable-languages=xxx

Alexandre Oliva aoliva@redhat.com
Wed Jul 9 18:07:00 GMT 2003


On Jul  9, 2003, Kelley Cook <kcook34@ford.com> wrote:

> Alexandre Oliva wrote:
>> Looks good, but I'd still tweak it a bit further.  You should use
>> ${SHELL} to run shell-scripts such as move-if-change, so how about
>> passing "$(SHELL) $(srcdir)/move-if-change"?

> Done.

Err...  You're passing down only the pathname to move-if-change, but
you can't assume that whatever the Makefile understands as ${SHELL}
will be available in opts.sh's environment.  You'll see that SHELL is
often set in the environment to something that is not necessarily
Bourne-shell compatible.  Users of csh variants would experience
problems.  Please pass a single quoted argument, as I suggested, and
run that as move-if-change.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer



More information about the Gcc-patches mailing list