[PATCH] Fix 10219

Mark Mitchell mark@codesourcery.com
Wed Jul 2 17:52:00 GMT 2003


On Wed, 2003-07-02 at 10:45, Richard Kenner wrote:
>     I think the convention is to always use "== error_mark_node", just
>     because there ought never be two nodes with code ERROR_MARK.
> 
> I argee we ought to use the same convention everywhere, but testing for
> ERROR_MARK is at least one less memory access on most machines, so there
> is a *tiny* advantage of using it.

We've had this discussion at least twice in the past, and there's never
been a clear outcome.  Some machines work one way, some another.  PIC
and non-PIC code generation makes a difference.

Please, let's not have this debate again.  It's not worth it.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com



More information about the Gcc-patches mailing list