[PATCH] PPC32: Fix libffi closure relocations

Franz Sirl Franz.Sirl-kernel@lauterbach.com
Thu Jan 30 00:03:00 GMT 2003


On Thursday 30 January 2003 00:33, Geoff Keating wrote:
> Franz Sirl <Franz.Sirl-kernel@lauterbach.com> writes:
> > Hi,
> >
> > after getting complaints from users and HJL about TEXTRELs in libgcj I
> > digged into this issue. It turned out that the coding style used in
> > ppc_closure.S simply is wrong in the shared lib case. Fortunately the
> > solution is simple and works for both static and shared case.
> >
> > Regtested on powerpc-linux-gnu, running ffitest passed too.
> >
> > OK to commit to mainline, 3.3 and 3.2?
>
> OK.  I wouldn't recommend this coding style in general, but it'll do
> for this case.

Yeah, I know, I did choose it because it looked like the least error prone one 
in the light of the different compilation modes for this file. No messing 
with GOT, -fpic, -fPIC and #ifdef :-).

Franz.



More information about the Gcc-patches mailing list