gcc/gcc/cp ChangeLog dump.c

Nathanael Nerode neroden@twcny.rr.com
Fri Jan 24 18:28:00 GMT 2003


Geoff Keating wrote:
> Nathanael Nerode <neroden@twcny.rr.com> writes:
> 
> 
>>>| CVSROOT:      /cvs/gcc
>>>| Module name:  gcc
>>>| Changes by:   neroden@gcc.gnu.org     2003-01-24 00:45:55
>>>| 
>>>| Modified files:
>>>|       gcc/cp         : ChangeLog dump.c 
>>>| 
>>>| Log message:
>>>|       * dump.c: ANSIfy function declarations and definitions.
>>>
>>>This patch wasn't approved at such.
>>>
>>>-- Gaby
>>
>>True.  You said that it was approved modulo some changes which turn 
>>out to be wrong.
> 
> 
> That is, "not approved".
> 
> 
>>In actual fact, I consider it obviously correct,
> 
> 
> Any patch that gets disapproved is never obviously correct.  Please
"Disapproved" is not the same as "not approved".

> don't do it again.

All right, but it is obviously correct.  I only submitted it out of 
politeness and conservatism; I'll be sure not to submit before 
committing patches I consider obvious next time.  You do realize that's 
what you just told me to do?

If you actually think the patch is wrong, go ahead and revert it.

--Nathanael



More information about the Gcc-patches mailing list