patch: Darwin/x86 fails to build

Stuart Hastings stuart@apple.com
Fri Jan 10 19:16:00 GMT 2003


On Thursday, Jan 9, 2003, at 15:05 US/Pacific, Richard Henderson wrote:

> On Thu, Jan 09, 2003 at 10:43:16AM -0800, Stuart Hastings wrote:
>> +         if (ix86_regparm > 2)
>> +           abort ();
>
> Why this bit?

You're right; it can go.  It got inherited by an accumulation of merges 
between the FSF and Apple versions.  It's originally from the previous 
FSF version of this function, pre-October-2002, and it appears to be 
useless today.  I'd assumed it was required for the NeXT Objective-C 
runtime; it's not.

How much testing would you require to resubmit the same patch without 
those two lines?

stuart hastings
Apple Computer



More information about the Gcc-patches mailing list