[3.4] DESTDIR support completed

Christian Cornelssen ccorn@cs.tu-berlin.de
Thu Jan 9 20:39:00 GMT 2003


Hi,

On Thu, 9 Jan 2003, Benjamin Kosnik wrote:

> On Thu, 9 Jan 2003 19:35:35 +0100 (CET)
> Christian Cornelssen <ccorn@cs.tu-berlin.de> wrote:
>
> >This is Automake's style.
>
> Seems kind of silly if you ask me.

It even seems silly (redundant) if I don't.  But when used
consequently, this style precisely ensures the semantics of DESTDIR,
i.e. that it is used only during installation and uninstallation. In
other cases, avoiding such redundancy would of course be desirable.

> If you'd like to patch up po/Makefile.am to remove the "disturbing"
> bits, and make it consistent with the rest of the install commands,
> please feel free.
>
> If this makes your scripts easier, so be it. In the future, however,
> please cc libstdc++ on its configuration patches before you check them
> in.

Let's return to the point: in `libstdc++-v3/include/Makefile.am',
there were two commands,

	$(mkinstalldirs) ${gxx_include_dir}/${c_base_builddir}
	$(mkinstalldirs) ${gxx_include_dir}/${std_builddir}

with directory arguments that were not used in subsequent
installations.  The subsequent installation commands got only
${gxx_include_dir}.  Actually, this makes no difference because
c_base_builddir and std_builddir are set to ".".  But then these
two mkinstalldirs commands are superfluous and should be removed,
or they should be left in, and the subsequent installations should be
equipped with the same arguments, for consistency.  I have done the
latter, and Alexandre asked for your opinion, that's all.

Regards,

Christian Cornelssen



More information about the Gcc-patches mailing list