PATCH gnatsweb.pl wrt to optimization/9086: Missing attachmentfor #9085

[Segher Boessenkool]

Jeroen van Bemmel wrote:
> 
> > Bugzilla suffers from the same problem.  Once your web browser changes
> > from URL, it forgets about file attachments you set in a form (and all
> > other values you set in the form), and rightfully so, because of
> > security considerations (or at least it should!)
> 
> Not all, but at least inputs of type 'file' and 'password'. The other fields
> are remembers, for example I don't have to type 'description' all over again
> when 'submit' detects a problem with my input

All file attachments I know are put in a "file" field... ;)

> Other than these, what other cases are there that cause 'submit' to fail ?

Can be anything, like some timeout or whatever you can imagine.

> > The third and easiest solution would be adding a field "number of
> attachments"
> > and having the server-side complain and the user rectify the problem
> > if this number is inconsistent with the actual received attachments.  A
> simple
> > flag "with attachments" might be enough, too.
> > I recommend this solution, as it's probably the most robust, and quite
> easy to
> > implement, too.  Sorry, no patch; I would have no way of testing it.
> 
> Problem with this is that it becomes hard for the user to change his mind:
> how can he
> remove the attachement again? The attachement field appears empty, yet the
> server complains since it has hidden state that the user cannot change.

I didn't say the flag should be hidden -- a checkbox or something like that
would probably do just fine.


Segher