ppc e500: misc <spe.h> patches

Daniel Jacobowitz drow@mvista.com
Wed Feb 12 22:54:00 GMT 2003


On Wed, Feb 12, 2003 at 08:57:02PM +0000, Graham Stott wrote:
> Hi Aldy,
> 
> Aldy Hernandez wrote:
> 
> >Index: config/rs6000/spe.h
> >===================================================================
> >RCS file: /cvs/gcc/gcc/gcc/config/rs6000/spe.h,v
> >retrieving revision 1.6
> >diff -c -p -r1.6 spe.h
> >*** config/rs6000/spe.h    21 Dec 2002 01:21:23 -0000    1.6
> >--- config/rs6000/spe.h    12 Feb 2003 20:23:55 -0000
> 
> 
> >  #define __ev_fsabs(a) ((__v2si) __builtin_spe_evfsabs ((__v2sf) a))
> >  #define __ev_fsnabs(a) ((__v2si) __builtin_spe_evfsnabs ((__v2sf) a))
> I know these aren't part of your patch but it looks like these two macros
> and possibly others need parentheses around the argument. Maybe you could
> address these in a follow up patch given that you're hacking this file.

I don't believe that's true - if A is the operand for a cast, and the
only argument to a function, there's no way for it to need additional
parentheses.  Since it comes in as a macro argument...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer



More information about the Gcc-patches mailing list