[PATCH] pow and atan2 builtin functions (part 3)

Richard Henderson rth@redhat.com
Tue Feb 11 18:16:00 GMT 2003


On Mon, Feb 10, 2003 at 08:07:21PM -0700, Roger Sayle wrote:
> + 	      case UNSPEC_FLDLG2:
> + 	      case UNSPEC_FLDLN2:
> + 	      case UNSPEC_FLDL2E:
> + 	      case UNSPEC_FLDL2T:
> + 	      case UNSPEC_FLDPI:

These I don't like.  I'd rather we matched the exact XFmode
value in standard_80387_constant_p.  See also the note about
these being slower than a load from memory on some targets.

The rest of it's ok.


r~



More information about the Gcc-patches mailing list