[rtlopt] use of alloc pools in var-tracking.c

Josef Zlomek zlomj9am@artax.karlin.mff.cuni.cz
Sun Feb 2 19:12:00 GMT 2003


> > this patch changes the allocation to use alloc-pool.c
> > It also fixes a memory leak (variable_htab was not freed)
> > and some comments.
> > 
> > Bootstrapped i386.
> > 
> > Josef
> > 
> > 2003-02-02  Josef Zlomek  <zlomekj@suse.cz>
> > 
> > 	* Makefile.in (var-tracking.o): Added dependency on alloc-pool.h.
> > 	* var-tracking.c: Fix some comments.
> > 	(attrs_pool): New variable.
> > 	(var_pool): New variable.
> > 	(variable_htab_free): New function.
> > 	(attrs_*_*): Use pool_alloc instead of xmalloc and pool_free instead of
> > 	free.
> > 	(set_location_part): Likewise.
> > 	(var_tracking_initialize): Create alloc pools, del_f for variable_htab
> > 	is variable_htab_free now.
> > 	(var_tracking_finalize): Delete variable_htab and alloc pools.
> > 	(variable_tracking_main): Remove debug dump.
> 
> Thanks!
> And please don't forget about the introductionary comment.  It is quite
> needed here :)

I am keeping this in my mind but have not written something yet.

> Also I noticed that some functions (iterative_dataflow, hybrid_search)
> do have same names as other functions in gcc.  This is not very good for
> debugging as you can't breakpoint them easilly.  Can you please invent
> some new names? 

OK,
if I do not invent some new name I'll at least add a prefix to their names :-)

Pepa



More information about the Gcc-patches mailing list