[C++ PATCH] [PR/13243] Detect more non constant expressions (regression in mainline)

[Giovanni Bajo]

Gabriel Dos Reis <gdr@integrable-solutions.net> wrote:

>> expression. Moreover, expressions like INDIRECT_REF and ADDR_EXPR are
>> always invalid as constant expressions.
>
> I am a bit nervous about that statement.  References get transformed
> (from time to time) into INDIRECT_REF, but a reference can be a valid
> constant expression.  The same is true for an ADDR_EXPR.  Did you check
> that?

Yes, I apologize for being unclear. What my patch disallows is "unary *" and
"unary &", which are directly built as INDIRECT_REF and ADDR_EXPR at parsing
time. If you look at the patch, the check is done within
cp_parser_unary_expression. I'm not disallowing those tree codes everywhere.
Does this sound better?

Giovanni Bajo