[tree-ssa] Patch ping

Zdenek Dvorak rakdver@atrey.karlin.mff.cuni.cz
Wed Dec 3 20:12:00 GMT 2003


Hello,

> > bool
> > cleanup_cond_expr_graph (basic_block bb, block_stmt_iterator bsi)
> > {
> >  <...>
> >   if (taken_edge->flags & EDGE_TRUE_VALUE)
> >     bsi_replace (&bsi, COND_EXPR_THEN (cond_expr), false);
> >   else if (taken_edge->flags & EDGE_FALSE_VALUE)
> >     bsi_replace (&bsi, COND_EXPR_ELSE (cond_expr), false);
> >   else
> >     abort ();
> 
> This, incidentally, is a bug.  We *cannot* use bsi_replace here.

not really sure why not; but just by pure coincidence this piece of code was removed
about two hours ago :-)

Zdenek



More information about the Gcc-patches mailing list