[tree-ssa][PATCH]: Have tree-sra dump info about why something wasn't scalarized

Daniel Berlin dberlin@dberlin.org
Mon Dec 1 14:55:00 GMT 2003


On Dec 1, 2003, at 6:21 AM, Diego Novillo wrote:

> On Sun, 2003-11-30 at 23:51, Daniel Berlin wrote:
>
>> 2003-11-31  Daniel Berlin  <dberlin@dberlin.org>
>> ^^^^^^^^^^
>>
> New calendar? ;)
>

Nah, I'm just hopeful that finals aren't coming as quick as they are :P.

>> 	* tree-sra.c (can_be_scalarized_p): Print details about why something
>> 	could not be scalarized to the dump file.
>>
> OK, with a minor change below.
>
>> @@ -166,7 +166,16 @@ can_be_scalarized_p (tree var)
>>     int nfields;
>>
>>     if (!is_gimple_non_addressable (var))
>> -    return false;
>> +    {
>> +      if (dump_file && (dump_flags & TDF_DETAILS))
>> +	{
>> +	  fprintf (dump_file, "Cannot scalarize variable ");
>> +	  print_generic_expr (dump_file, var, 0);	
>> +	  fprintf (dump_file,
>> +		   " because it is not a GIMPLE addressable var\n");
>> +	}
>> +      return false;
>> +    }
>>
> The message is a bit misleading here.  It should say "it's not a GIMPLE
> non-addressable", but the double negation is confusing.  How about,
> something like "it needs to live in memory" or something along those
> lines (this happens when the structure is static, non-locals, 
> volatiles,
> etc).

Sure.

>
>
> Diego.
>



More information about the Gcc-patches mailing list