[mainline] C++ PATCH: Tidy name hiding

Gabriel Dos Reis gdr@integrable-solutions.net
Sat Aug 30 07:04:00 GMT 2003


Mark Mitchell <mark@codesourcery.com> writes:

[...]

| > Also, since that function is actually hiding a declaration for a name,
| > I renamed it to cxx_binding_hide_name.
| 
| I like everything in your patch, except the change of name.
| 
| The "hide_name" name makes me think that somehow the name is going to be
| hidden, which it's not -- it's just that the type binding will require
| an elaborated-type-specifier.
| 
| I actually think add_binding is OK, but supplement_binding might be
| better?

Go for supplement_binding.  I'll resend an iteration I did sinice then,
with your suggestion incorporated.

-- Gaby



More information about the Gcc-patches mailing list