[patch] libffi darwin structure implementation (PPC)
Andrew Pinski
pinskia@physics.uc.edu
Fri Aug 29 19:10:00 GMT 2003
> Comments are welcome.
Only two comments/suggestions.
> + tramp[1] = 0x4800000d; /* bl 10 <trampoline_initial+0x10> */
Since this messes up the lr stack which is a speed lose, can you can change it to "bcl 20,31,0x10"?
Also change the following so they do not use cats as lvalue GCC extension as we really want to get rid of it:
+ *(void **) &tramp[2] = (void *)ffi_closure_ASM; /* function */
+ *(void **) &tramp[3] = (void *)closure; /* context */
I know that you really did not change any thing around this but it would be nice for these two changes.
Thanks,
Andrew Pinski
More information about the Gcc-patches
mailing list