Patch [3.3.x] for -Wtraditional (and other) warnings

[Kaveh R. Ghazi]

Since 3.3.x is our last series which supports bootstrap with a K&R
stage1 compiler, we should try to ensure it works.  There were some
-Wtraditional warning regressions as well as a couple of other simple
warning regressions which I fixed while I was doing this sweep.

This patch fixes the following:

 > stmt.c:1739: warning: traditional C rejects string concatenation
 > tree.c:4355: warning: traditional C rejects ISO C style function definitions
 > varasm.c:2664: warning: unused variable `size'
 > cp/typeck.c:2646: warning: unused parameter `require_complete'
 > cp/decl.c:464: warning: `p' might be used uninitialized in this function

Bootstrapped on sparc-sun-solaris2.7, no regressions.

Ok for 3.3.x branch?

		Thanks,
		--Kaveh


2003-08-16  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>

	* stmt.c (expand_asm_operands): Avoid string concatenation.
	* tree.c (default_flag_random_seed): Avoid ISO C definition.
	* varasm.c (output_constant_def): Delete unused variable.
	
cp:
	* cp-tree.h (build_function_call_real): Remove unused parameter.
	* typeck.c (build_function_call_real): Likewise.  Caller changed.
	* decl.c (binding_table_reverse_maybe_remap): Initialize variable.

diff -rup orig/egcc-3.3-CVS20030816/gcc/stmt.c egcc-3.3-CVS20030816/gcc/stmt.c
--- orig/egcc-3.3-CVS20030816/gcc/stmt.c	2003-06-12 20:08:18.000000000 -0400
+++ egcc-3.3-CVS20030816/gcc/stmt.c	2003-08-16 21:22:10.792677726 -0400
@@ -1735,8 +1735,8 @@ expand_asm_operands (string, outputs, in
 	    }
 	  else
 	    {
-	      warning ("use of memory input without lvalue in "
-		       "asm operand %d is deprecated", i + noutputs);
+	      warning ("use of memory input without lvalue in asm operand %d is deprecated",
+		       i + noutputs);
 
 	      if (CONSTANT_P (op))
 		{
diff -rup orig/egcc-3.3-CVS20030816/gcc/tree.c egcc-3.3-CVS20030816/gcc/tree.c
--- orig/egcc-3.3-CVS20030816/gcc/tree.c	2003-06-20 22:37:08.000000000 -0400
+++ egcc-3.3-CVS20030816/gcc/tree.c	2003-08-16 21:23:13.338768512 -0400
@@ -4351,7 +4351,7 @@ const char *flag_random_seed;
 /* Set up a default flag_random_seed value, if there wasn't one already.  */
 
 void
-default_flag_random_seed (void)
+default_flag_random_seed ()
 {
   unsigned HOST_WIDE_INT value;
   char *new_random_seed;
diff -rup orig/egcc-3.3-CVS20030816/gcc/varasm.c egcc-3.3-CVS20030816/gcc/varasm.c
--- orig/egcc-3.3-CVS20030816/gcc/varasm.c	2003-08-08 20:05:51.000000000 -0400
+++ egcc-3.3-CVS20030816/gcc/varasm.c	2003-08-16 21:15:22.796739131 -0400
@@ -2661,7 +2661,6 @@ output_constant_def (exp, defer)
   int after_function = 0;
   int labelno = -1;
   rtx rtl;
-  HOST_WIDE_INT size;
 
 
   /* We can't just use the saved RTL if this is a deferred string constant
diff -rup orig/egcc-3.3-CVS20030816/gcc/cp/cp-tree.h egcc-3.3-CVS20030816/gcc/cp/cp-tree.h
--- orig/egcc-3.3-CVS20030816/gcc/cp/cp-tree.h	2003-07-25 20:06:02.000000000 -0400
+++ egcc-3.3-CVS20030816/gcc/cp/cp-tree.h	2003-08-16 21:17:57.303400992 -0400
@@ -4405,7 +4405,7 @@ extern tree build_x_indirect_ref		PARAMS
 extern tree build_indirect_ref			PARAMS ((tree, const char *));
 extern tree build_array_ref			PARAMS ((tree, tree));
 extern tree get_member_function_from_ptrfunc	PARAMS ((tree *, tree));
-extern tree build_function_call_real		PARAMS ((tree, tree, int, int));
+extern tree build_function_call_real		PARAMS ((tree, tree, int));
 extern tree build_function_call_maybe		PARAMS ((tree, tree));
 extern tree convert_arguments			PARAMS ((tree, tree, tree, int));
 extern tree build_x_binary_op			PARAMS ((enum tree_code, tree, tree));
diff -rup orig/egcc-3.3-CVS20030816/gcc/cp/typeck.c egcc-3.3-CVS20030816/gcc/cp/typeck.c
--- orig/egcc-3.3-CVS20030816/gcc/cp/typeck.c	2003-07-06 20:06:04.000000000 -0400
+++ egcc-3.3-CVS20030816/gcc/cp/typeck.c	2003-08-16 21:17:39.314977125 -0400
@@ -2641,9 +2641,9 @@ get_member_function_from_ptrfunc (instan
 }
 
 tree
-build_function_call_real (function, params, require_complete, flags)
+build_function_call_real (function, params, flags)
      tree function, params;
-     int require_complete, flags;
+     int flags;
 {
   register tree fntype, fndecl;
   register tree coerced_params;
@@ -2757,7 +2757,7 @@ tree
 build_function_call (function, params)
      tree function, params;
 {
-  return build_function_call_real (function, params, 1, LOOKUP_NORMAL);
+  return build_function_call_real (function, params, LOOKUP_NORMAL);
 }
 
 /* Convert the actual parameter expressions in the list VALUES
diff -rup orig/egcc-3.3-CVS20030816/gcc/cp/decl.c egcc-3.3-CVS20030816/gcc/cp/decl.c
--- orig/egcc-3.3-CVS20030816/gcc/cp/decl.c	2003-07-25 20:06:02.000000000 -0400
+++ egcc-3.3-CVS20030816/gcc/cp/decl.c	2003-08-16 21:19:45.993931065 -0400
@@ -461,7 +461,7 @@ binding_table_reverse_maybe_remap (bindi
 {
   const size_t chain_count = table->chain_count;
   binding_entry entry = NULL;
-  binding_entry *p;
+  binding_entry *p = NULL;
   size_t i;
 
   for (i = 0; i < chain_count && entry == NULL; ++i)