Unreviewed patch
Richard Sandiford
rsandifo@redhat.com
Wed Aug 13 09:02:00 GMT 2003
This one didn't get a review:
http://gcc.gnu.org/ml/gcc-patches/2003-06/msg02768.html
It's the trunk version of:
http://gcc.gnu.org/ml/gcc-patches/2003-06/msg02766.html
OK to install?
One thing I forgot to mention in the covering note was that:
/* va_arg is an array access in this case, which causes
it to get MEM_IN_STRUCT_P set. We must set it here
so that the insn scheduler won't assume that these
stores can't possibly overlap with the va_arg loads. */
if (mips_abi != ABI_EABI && BYTES_BIG_ENDIAN)
MEM_SET_IN_STRUCT_P (mem, 1);
(which dates back to '96) seems bogus. Looking at the rtl dumps, va_arg
loads don't have MEM_IN_STRUCT_P set for any combination that I can see.
Certainly not for -mabi=n32 and -mabi=64 on irix (which is a big endian
target). Having them only on the stores, not the loads, seems dangerous.
Richard
More information about the Gcc-patches
mailing list