Approval: can I commit this please?

Geoff Keating
Sun Apr 20 02:31:00 GMT 2003

"Kean Johnston" <> writes:

> The first patch is to It detects the GNU
> linker, and only used ld -shared if the GNU linker is
> being used. It used -G else. It also adds /usr/ccs/bin/elf
> to the list of search directories looking for tools, and it
> corrects a test for RO/RW section mixing. The second patch
> is to tlink.c, it adds missing = signs to the putenv calls.
> Someone previously wondered why the arguments to putenv are
> xstrdup'ed in the first place, and I can only assume that
> it helps eliminate warnings, as some systems declare putenv
> to take a char * instead of a const char *.
> If someone can give me the nod I'll commit these two changes,
> it's the last of the stuff required to get the SCO port working.

Are you sure this won't break all the ports that aren't SCO and don't
use GNU ld?

The patch also needs a ChangeLog.

- Geoffrey Keating <>

More information about the Gcc-patches mailing list