[PATCH] nreverse

Mark Mitchell mark@codesourcery.com
Wed Apr 16 02:41:00 GMT 2003


On Tue, 2003-04-15 at 17:30, Richard Henderson wrote:
> On Tue, Apr 15, 2003 at 12:34:52PM -0700, Mark Mitchell wrote:
> > The nreverse_fn change is OK -- but you need comments for the macro, and
> > they need to mention that it evaluates T more than once.
> 
> This is a killer IMO.  If you must, use an inline function,
> and not a macro.

We can do that, but then when using a compiler that doesn't support
inline, you'll pay two function calls instead of one.

We've already got lots of macros with this "feature"; see most of the
TYPE_P macros for example.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com



More information about the Gcc-patches mailing list