C++ PATCH: Fix PR 10300
Mark Mitchell
mark@codesourcery.com
Mon Apr 14 04:07:00 GMT 2003
On Sun, 2003-04-13 at 20:45, Jason Merrill wrote:
> On Sun, 13 Apr 2003 10:50:29 -0700, Mark Mitchell <mark@codesourcery.com> wrote:
>
> > ! null_node = convert (TREE_TYPE (alloc_node),
> > ! cookie_size ? cookie_size : size_zero_node);
>
> This seems unfortunate; comparing to zero is significantly faster on most
> targets. I'd prefer a solution further toward your mainline patch.
I thought about that, but didn't feel it was worth the trouble. This
only comes up when we're using "new (nothrow) X[]" for X a type with a
destructor, which isn't that often, and in that case we're making at
least one function call (the new operator) and probably more (the
constructors for the Xs), so one extra load-immediate isn't going to
kill us.
And this patch is very minimal.
-- Mark
More information about the Gcc-patches
mailing list