3.4 i386 code generation problem with leal

Jan Hubicka jh@suse.cz
Tue Apr 8 07:33:00 GMT 2003


> On Mon, Apr 07, 2003 at 10:10:08PM +0200, Jan Hubicka wrote:
> >       case UNSPEC_GOTOFF:
> > +       if (GET_CODE (XVECEXP (disp, 0, 0)) == SYMBOL_REF
> > + 	  || GET_CODE (XVECEXP (disp, 0, 0)) == LABEL_REF)
> >         return local_symbolic_operand (XVECEXP (disp, 0, 0), Pmode);
> >       case UNSPEC_GOTTPOFF:
> 
> If you're intending to fall thru, please write /* FALLTHRU */.

Actually it wasn't intended to fallthru at all (even when the fallthru
in the turn resulted in correct decision.  I've added missing return
false.  Thanks!

Honza
> 
> Otherwise ok.
> 
> 
> r~



More information about the Gcc-patches mailing list