RFC: Remove TREE_CST_RTL

[Zack Weinberg]

Hans-Peter Nilsson <hp@bitrange.com> writes:

>> +  if (flag_pic)
>> +    SYMBOL_REF_FLAG (XEXP (rtl, 0)) = 1;
>
> IIUC, that last line should be
>   SYMBOL_REF_FLAG (XEXP (rtl, 0)) = (*targetm.binds_local_p) (exp);

If you trace the calls, you find that constant-pool entries always
count as local symbols, so there's no point in calling binds_local_p.
(And if you think about it, that is as it should be.)

This is a convenient place to warn everyone not to bother trying to
apply and test these patches -- it turns out I have to change all the
places where CONSTRUCTOR nodes get created.  I'll send a new patch
tomorrow.  (Commenting on the code as you see it is still
appreciated.)

zw