#pragma weak is broken in 3.1, partail fix

[Marc Espie]

In article <20020525204334.A28290@redhat.com> you write:
>On Sat, May 25, 2002 at 10:55:38AM +0200, Marc Espie wrote:
>> * one is structural:   I don't understand how new code to handle #pragma
>> weak could have been written and never even TESTED on any testcase before
>> being committed.

>I thought there were tests for this.  Clearly not.  Rectified.

I think you are overly optimistic.

I'm pretty sure there are no tests in gcc for most of the things we may break.

In general, I tend to think of the testsuite as a last chance safety net.

It definitely doesn't replace careful coding and testing of code: it's not
comprehensive enough to even begin to replace straight thinking.

Of course, you may have another opinion. :-)