RFA: Ignore DOS end-of-line characters (ctrl-Z) unless -W
pavenis@lanet.lv
pavenis@lanet.lv
Thu May 9 09:35:00 GMT 2002
On 9 May 2002 at 8:42, Zack Weinberg wrote:
> On Thu, May 09, 2002 at 01:14:53PM +0300, pavenis@lanet.lv wrote:
> >
> > OK. Here it is (tested for DJGPP with 3.1 branch)
>
> O_TEXT, not O_BINARY. Also, based on other discussion with Eli, the
> check should apply to all file descriptors, not just stdin, so please
> move it below the call to open.
>
I don't think so.
With O_TEXT we will run into another trouble as length of data in memory will
be smaller than one in file. As result read_include_file() will complain that
input file is shorter than expected.
So unless we want to remove that check, O_BINARY must stay there.
Current patch changes mode to O_BINARY in rather specific case when
one is feeding source in gcc from pipe. For example
cat foo.c | gcc -c -x c -o foo.o -
In this case file is opened in text mode by default, and I'm getting a warning
I mentioned above.
Andris
More information about the Gcc-patches
mailing list