[PATCH] Fix PR target/6429 (take 2)

Jakub Jelinek jakub@redhat.com
Tue May 7 13:39:00 GMT 2002


On Tue, May 07, 2002 at 03:07:14PM -0300, Alexandre Oliva wrote:
> > +	rm -f $(SHLIB_SOLINK) && \
> > +	$(LN_S) $(SHLIB_NAME) $(SHLIB_SOLINK)
> 
> No `&&' after `rm -f' unless you're sure the file is there; use `;'
> instead, or the even safer `{ rm -f foo || : ; } &&'.  Some stupid `rm
> -f's return non-zero exit status even though they don't otherwise
> complain when the file to be removed does not exist.  Yeah, it was
> already broken before, but...

Well, the makefile fragment is there only for a couple of architectures
and nobody complained yet for those. I'm not sure if this need changing for
3.1.

> This sed command is dangerous should base_ml_dir ever contain
> sed-active regexp characters.

In this patch the only acceptable $base_ml_dir chars are [a-z][0-9], so it
should be fine. Rainer has done changes for Irix6 and is testing them,
and there is = allowed additionally, he has done some -e 's/=/$(EQ)/g'
additions.

	Jakub



More information about the Gcc-patches mailing list