GCC build failed for native with your patch on 2002-03-06T18:46:34Z.

Jan Hubicka jh@suse.cz
Fri Mar 8 11:49:00 GMT 2002


> On Thu, Mar 07, 2002 at 02:08:07PM +0100, Jan Hubicka wrote:
> > 	* gcse.c (hash_scan_set): Refuse instructions with EH edges.
> 
> This seems like the best solution for the branch, certainly.
> For mainline, I'd eventually like to be able to split EH edges;
> this is certainly ok for the moment though.

Splitting EH edges sound like good idea.  How this can be done?
We will still need this mechanizm in GCSE for trapping computed jumps
that will have both splittable and unsplittable edges
(I would like to teach commit_edge_insertions to split all edges
that targets to block with only one unsplittable reaching abnormal edge,
but in general case...)
> 
> > + 	  /* GCSE commonly inserts instruction after the insn.  We can't
> > + 	     do that easily for EH_REGION notes so disable GCSE on these
> > + 	     for now.  */
> > + 	  && !find_reg_note (insn, REG_EH_REGION, NULL_RTX)
> 
> I'd prefer you use can_throw_internal.

Would be OK to commit to the branch with this change and modify the
mainline?

Honza
> 
> 
> r~



More information about the Gcc-patches mailing list