[tree-ssa-branch] simplify builtins

[Diego Novillo]

On Thu, 27 Jun 2002, Aldy Hernandez wrote:

> 1. is_string_plus_int() was just replicating string_constant() which is
>    what the expand_builtins were using.  so now i just call that.
>    less code, cleaner, and catches more corner cases :).
> 
OK.  Good thing you spotted this one.

> 2. is_simple_compound_lval() was bailing out on INDIRECT_REFs, so it
>    never got a chance to call is_simple_min_lval().  this was causing
>    a vararg regression.
> 
No.  This seems wrong.  This change will cause
is_simple_compound_lval() to return true on any indirect
reference like *p.  This predicate is supposed to accept array or
structure references.  You're likely papering over some other
bug.

When you get the simplification error, backtrack inside the
debugger to see what the caller was expecting to get.  I'll take
a look with this part of the patch disabled.

Diego.