ip2k port reviewing/accepting

[Denis Chertykov]

Denis Chertykov <denisc@overta.ru> writes:

> Geoff Keating <geoffk@geoffk.org> writes:
> 
> > > Cc: Denis Chertykov <denisc@overta.ru>, gcc-patches@gcc.gnu.org
> > > From: Denis Chertykov <denisc@overta.ru>
> > > Date: 20 Jun 2002 01:10:13 +0400
> > > User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7
> > > X-OriginalArrivalTime: 19 Jun 2002 21:06:14.0281 (UTC) FILETIME=[25678790:01C217D5]
> > > 
> > > Geoff Keating <geoffk@geoffk.org> writes:
> > > 
> > > > 
> > > > It seems generally OK, but:
> > > > 
> > > > - It needs a ChangeLog entry
> > > 
> > > I send it separate.
> > > 
> > > > - You need to update the documentation, in particular the constraints
> > > >   need to be documented
> > > 
> > > Will be sended shortly.
> > > IMHO: better to have a separate patch for documentation.
> > > (Do not mix them with config/ip2k/* files).
> > > Must I got approval for committing patch for documentation ?
> > > 
> > > > - In cases like this:
> > > > 
> > > > #if 0 /* FIXME: denisc@overta.ru */
> > > 
> > > [...]
> > > 
> > > > 
> > > > There are some minor things that you might consider doing now or after
> > > > the port is committed:
> > > 
> > > I prefer to have a ChangeLog entries for all such changes.
> > > 
> > > > - change all occurrences of "gen_rtx (XXX, " into "gen_rtx_XXX (" for
> > > >   all 'XXX', for instance in INIT_TARGET_OPTABS.  There are many
> > > >   instances, be sure to get them all.
> > > 
> > > Will be done.
> > > 
> > > Can I commit port now ? 
> > 
> > Please send a revised patch.

What you mean ?
I can commit a revised patch or I must got approval.

Denis.