[patch] Tweak _sch_test() to deal with c >= 256 correctly

Zack Weinberg zack@codesourcery.com
Tue Jun 18 18:16:00 GMT 2002


On Tue, Jun 18, 2002 at 02:32:05PM -0700, Matt Hiller wrote:
> On Sun, 16 Jun 2002, Alan Modra wrote:
> 
> > On Wed, Jun 12, 2002 at 05:16:40PM -0700, Matt Hiller wrote:
> > > Am I missing something about the way that _sch_test works such that the
> > > existing code is correct?
> > 
> > The "(c) & 0xff" is to make array indexing work when "c" is a signed char.
> 
> Ah. So the correct thing is simply to add to what was there already:
> 
> 2002-06-18  Matt Hiller  <hiller@redhat.com>
> 
> 	* safe-ctype.h (_sch_test): Check that -128 <= c <= 255 
> 	before proceeding; otherwise evaluate to 0.

This seems like a sane thing to do, but can I ask the context in which
you are having a problem with what's there now?

zw



More information about the Gcc-patches mailing list