peer review on TARGET_*_CPP_BUILTINS

Zack Weinberg zack@codesourcery.com
Mon Jun 10 14:21:00 GMT 2002


On Mon, Jun 10, 2002 at 02:07:39PM -0700, cgd@broadcom.com wrote:
> Err, so, in the ! TARGET_64BIT chunk of code, it does:
> 
> +         builtin_define ("__mips");                            \
> 
> The for each ISA it does, e.g.:
> 
> +         builtin_define ("__mips=1");                          \
> 
> with the ISA number.

This has nothing to do with the point you were making, but I thought I
should mention that those two calls to builtin_define have exactly the
same effect.  builtin_define is piggybacked on the -D command line
switch handling, and if you don't give -D a definition, the macro gets
the value 1.  Which is normally the right value for these builtins.

If you want to define a macro to the empty string you have to write
builtin_define ("__mips=").

zw



More information about the Gcc-patches mailing list