Patch: gcc/Makefile.in bug fixes

Geoff Keating geoffk@geoffk.org
Mon Jun 10 10:46:00 GMT 2002


Tom Tromey <tromey@redhat.com> writes:

> This patch fixes a couple apparent Makefile.in buglets.
> 
> The first bug is that LANGHOOKS_DEF_H doesn't mention
> langhooks-def.h.  I think this is just a simple oversight, and that
> the langhooks.h inclusion is a typo.
> 
> The second bug is that c-common.o doesn't depend on langhooks.h, but
> c-common.c includes that file.
> 
> Tested with a PPC Linux build.  I noticed these problems when I added
> a new langhook and the resulting compiler failed to work.
> 
> Ok to commit?

This is OK.

> Index: ChangeLog
> from  Tom Tromey  <tromey@redhat.com>
> 
> 	* Makefile.in (LANGHOOKS_DEF_H): Include langhooks-def.h.
> 	(c-common.o): Depend on langhooks.h.
> 
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/Makefile.in,v
> retrieving revision 1.893
> diff -u -r1.893 Makefile.in
> --- Makefile.in 10 Jun 2002 13:37:24 -0000 1.893
> +++ Makefile.in 10 Jun 2002 17:12:58 -0000
> @@ -544,7 +544,7 @@
>  TCONFIG_H = tconfig.h $(xm_file_list)
>  TARGET_H = target.h
>  HOOKS_H = hooks.h
> -LANGHOOKS_DEF_H = langhooks.h $(HOOKS_H)
> +LANGHOOKS_DEF_H = langhooks-def.h $(HOOKS_H)
>  TARGET_DEF_H = target-def.h $(HOOKS_H)
>  TM_P_H = tm_p.h $(tm_p_file_list) tm-preds.h
>  
> @@ -1231,7 +1231,7 @@
>  c-common.o : c-common.c $(CONFIG_H) $(SYSTEM_H) $(TREE_H) $(OBSTACK_H) \
>  	$(C_COMMON_H) flags.h toplev.h output.h c-pragma.h $(RTL_H) $(GGC_H) \
>  	$(EXPR_H) $(TM_P_H) builtin-types.def builtin-attrs.def $(TARGET_H) \
> -	diagnostic.h tree-inline.h except.h gt-c-common.h real.h
> +	diagnostic.h tree-inline.h except.h gt-c-common.h real.h langhooks.h
>  
>  # A file used by all variants of C and some other languages.
> 

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>



More information about the Gcc-patches mailing list