[RFA] Numbers patch, take 2.

Neil Booth neil@daikokuya.demon.co.uk
Sun Jun 2 02:28:00 GMT 2002


The previous one was not so readable as a unified diff.  I've
also changed a testcase that becomes XPASS with this patch to
PASS.

Bootstrapped and regtested.  OK?

Neil.

	* c-common.c (c_common_init): Override cpplib's default
	warn_long_long setting.
	* c-lex.c (lex_number): Replace with interpret_integer,
	interpret_float, narrowest_unsigned_type and
	narrowest_signed_type, taking advantage of the new
	cpplib functionality.
	* cpperror.c (_cpp_begin_message): If a warning is turned
	into an error, avoid printing "warning:".
	* cppexp.c (cpp_num_sign_extend): New.
	* cppinit.c: Update comment.
	* cpplib.h (cpp_num_sign_extend): New.
	* tree.h: Update comment.
testsuite:
	* gcc.dg/wtr-int-type-1.c, gcc.dg/wtr-suffix-1.c,
	gcc.dg/cpp/paste4.c, gcc.dg/cpp/sysmac2.c,
	Update for mofified diagnostics.
	* gcc.dg/c99-inconst-1.c: Remove XFAIL.

============================================================
Index: gcc/c-common.c
*** gcc/c-common.c	31 May 2002 06:01:15 -0000	1.339
--- gcc/c-common.c	2 Jun 2002 09:25:25 -0000
*************** c_common_init (filename)
*** 4510,4515 ****
--- 4510,4519 ----
    options->warn_multichar = warn_multichar;
    options->stdc_0_in_system_headers = STDC_0_IN_SYSTEM_HEADERS;
  
+   /* We want -Wno-long-long to override -pedantic -std=non-c99
+      whatever the ordering.  */
+   options->warn_long_long = warn_long_long && !flag_isoc99 && pedantic;
+ 
    /* Register preprocessor built-ins before calls to
       cpp_main_file.  */
    cpp_get_callbacks (parse_in)->register_builtins = cb_register_builtins;
============================================================
Index: gcc/c-lex.c
*** gcc/c-lex.c	28 May 2002 17:32:12 -0000	1.180
--- gcc/c-lex.c	2 Jun 2002 09:25:25 -0000
*************** int c_header_level;	 /* depth in C heade
*** 73,79 ****
  /* Nonzero tells yylex to ignore \ in string constants.  */
  static int ignore_escape_flag;
  
! static tree lex_number		PARAMS ((const char *, unsigned int));
  static tree lex_string		PARAMS ((const unsigned char *, unsigned int,
  					 int));
  static tree lex_charconst	PARAMS ((const cpp_token *));
--- 73,84 ----
  /* Nonzero tells yylex to ignore \ in string constants.  */
  static int ignore_escape_flag;
  
! static tree interpret_integer	PARAMS ((const cpp_token *, unsigned int));
! static tree interpret_float	PARAMS ((const cpp_token *, unsigned int));
! static enum integer_type_kind
!   narrowest_unsigned_type	PARAMS ((tree, unsigned int));
! static enum integer_type_kind
!   narrowest_signed_type		PARAMS ((tree, unsigned int));
  static tree lex_string		PARAMS ((const unsigned char *, unsigned int,
  					 int));
  static tree lex_charconst	PARAMS ((const cpp_token *));
*************** utf8_extend_token (c)
*** 664,689 ****
    while (shift);
  }
  #endif
- 
- #if 0
- struct try_type
- {
-   tree *const node_var;
-   const char unsigned_flag;
-   const char long_flag;
-   const char long_long_flag;
- };
- 
- struct try_type type_sequence[] =
- {
-   { &integer_type_node, 0, 0, 0},
-   { &unsigned_type_node, 1, 0, 0},
-   { &long_integer_type_node, 0, 1, 0},
-   { &long_unsigned_type_node, 1, 1, 0},
-   { &long_long_integer_type_node, 0, 1, 1},
-   { &long_long_unsigned_type_node, 1, 1, 1}
- };
- #endif /* 0 */
  
  int
  c_lex (value)
--- 669,674 ----
*************** c_lex (value)
*** 719,725 ****
        break;
  
      case CPP_NUMBER:
!       *value = lex_number ((const char *)tok->val.str.text, tok->val.str.len);
        break;
  
      case CPP_CHAR:
--- 704,730 ----
        break;
  
      case CPP_NUMBER:
!       {
! 	unsigned int flags = cpp_classify_number (parse_in, tok);
! 
! 	switch (flags & CPP_N_CATEGORY)
! 	  {
! 	  case CPP_N_INVALID:
! 	    /* cpplib has issued an error.  */
! 	    break;
! 
! 	  case CPP_N_INTEGER:
! 	    *value = interpret_integer (tok, flags);
! 	    break;
! 
! 	  case CPP_N_FLOATING:
! 	    *value = interpret_float (tok, flags);
! 	    break;
! 
! 	  default:
! 	    abort ();
! 	  }
!       }
        break;
  
      case CPP_CHAR:
*************** c_lex (value)
*** 745,1213 ****
    return tok->type;
  }
  
! #define ERROR(msgid) do { error(msgid); goto syntax_error; } while(0)
! 
! static tree
! lex_number (str, len)
!      const char *str;
!      unsigned int len;
  {
!   int base = 10;
!   int count = 0;
!   int largest_digit = 0;
!   int numdigits = 0;
!   int overflow = 0;
!   int c;
!   tree value;
!   const char *p;
!   enum anon1 { NOT_FLOAT = 0, AFTER_POINT, AFTER_EXPON } floatflag = NOT_FLOAT;
!   
!   /* We actually store only HOST_BITS_PER_CHAR bits in each part.
!      The code below which fills the parts array assumes that a host
!      int is at least twice as wide as a host char, and that 
!      HOST_BITS_PER_WIDE_INT is an even multiple of HOST_BITS_PER_CHAR.
!      Two HOST_WIDE_INTs is the largest int literal we can store.
!      In order to detect overflow below, the number of parts (TOTAL_PARTS)
!      must be exactly the number of parts needed to hold the bits
!      of two HOST_WIDE_INTs.  */
! #define TOTAL_PARTS ((HOST_BITS_PER_WIDE_INT / HOST_BITS_PER_CHAR) * 2)
!   unsigned int parts[TOTAL_PARTS];
!   
!   /* Optimize for most frequent case.  */
!   if (len == 1)
!     {
!       if (*str == '0')
! 	return integer_zero_node;
!       else if (*str == '1')
! 	return integer_one_node;
!       else
! 	return build_int_2 (*str - '0', 0);
!     }
! 
!   for (count = 0; count < TOTAL_PARTS; count++)
!     parts[count] = 0;
! 
!   /* len is known to be >1 at this point.  */
!   p = str;
! 
!   if (len > 2 && str[0] == '0' && (str[1] == 'x' || str[1] == 'X'))
!     {
!       base = 16;
!       p = str + 2;
!     }
!   /* The ISDIGIT check is so we are not confused by a suffix on 0.  */
!   else if (str[0] == '0' && ISDIGIT (str[1]))
!     {
!       base = 8;
!       p = str + 1;
!     }
! 
!   do
!     {
!       c = *p++;
! 
!       if (c == '.')
! 	{
! 	  if (floatflag == AFTER_POINT)
! 	    ERROR ("too many decimal points in floating constant");
! 	  else if (floatflag == AFTER_EXPON)
! 	    ERROR ("decimal point in exponent - impossible!");
! 	  else
! 	    floatflag = AFTER_POINT;
! 
! 	  if (base == 8)
! 	    base = 10;
! 	}
!       else if (c == '_')
! 	/* Possible future extension: silently ignore _ in numbers,
! 	   permitting cosmetic grouping - e.g. 0x8000_0000 == 0x80000000
! 	   but somewhat easier to read.  Ada has this?  */
! 	ERROR ("underscore in number");
!       else
! 	{
! 	  int n;
! 	  /* It is not a decimal point.
! 	     It should be a digit (perhaps a hex digit).  */
! 
! 	  if (ISDIGIT (c)
! 	      || (base == 16 && ISXDIGIT (c)))
! 	    {
! 	      n = hex_value (c);
! 	    }
! 	  else if (base <= 10 && (c == 'e' || c == 'E'))
! 	    {
! 	      base = 10;
! 	      floatflag = AFTER_EXPON;
! 	      break;
! 	    }
! 	  else if (base == 16 && (c == 'p' || c == 'P'))
! 	    {
! 	      floatflag = AFTER_EXPON;
! 	      break;   /* start of exponent */
! 	    }
! 	  else
! 	    {
! 	      p--;
! 	      break;  /* start of suffix */
! 	    }
! 
! 	  if (n >= largest_digit)
! 	    largest_digit = n;
! 	  numdigits++;
! 
! 	  for (count = 0; count < TOTAL_PARTS; count++)
! 	    {
! 	      parts[count] *= base;
! 	      if (count)
! 		{
! 		  parts[count]
! 		    += (parts[count-1] >> HOST_BITS_PER_CHAR);
! 		  parts[count-1]
! 		    &= (1 << HOST_BITS_PER_CHAR) - 1;
! 		}
! 	      else
! 		parts[0] += n;
! 	    }
! 
! 	  /* If the highest-order part overflows (gets larger than
! 	     a host char will hold) then the whole number has 
! 	     overflowed.  Record this and truncate the highest-order
! 	     part.  */
! 	  if (parts[TOTAL_PARTS - 1] >> HOST_BITS_PER_CHAR)
! 	    {
! 	      overflow = 1;
! 	      parts[TOTAL_PARTS - 1] &= (1 << HOST_BITS_PER_CHAR) - 1;
! 	    }
! 	}
!     }
!   while (p < str + len);
! 
!   /* This can happen on input like `int i = 0x;' */
!   if (numdigits == 0)
!     ERROR ("numeric constant with no digits");
! 
!   if (largest_digit >= base)
!     ERROR ("numeric constant contains digits beyond the radix");
! 
!   if (floatflag != NOT_FLOAT)
!     {
!       tree type;
!       const char *typename;
!       int imag, fflag, lflag;
!       REAL_VALUE_TYPE real;
!       char *copy;
! 
!       if (base == 16 && floatflag != AFTER_EXPON)
! 	ERROR ("hexadecimal floating constant has no exponent");
! 
!       /* Read explicit exponent if any, and put it in tokenbuf.  */
!       if ((base == 10 && ((c == 'e') || (c == 'E')))
! 	  || (base == 16 && (c == 'p' || c == 'P')))
! 	{
! 	  if (p < str + len)
! 	    c = *p++;
! 	  if (p < str + len && (c == '+' || c == '-'))
! 	    c = *p++;
! 	  /* Exponent is decimal, even if string is a hex float.  */
! 	  if (! ISDIGIT (c))
! 	    ERROR ("floating constant exponent has no digits");
! 	  while (p < str + len && ISDIGIT (c))
! 	    c = *p++;
! 	  if (! ISDIGIT (c))
! 	    p--;
! 	}
! 
!       /* Copy the float constant now; we don't want any suffixes in the
! 	 string passed to parse_float.  */
!       copy = alloca (p - str + 1);
!       memcpy (copy, str, p - str);
!       copy[p - str] = '\0';
  
!       /* Now parse suffixes.  */
!       fflag = lflag = imag = 0;
!       while (p < str + len)
! 	switch (*p++)
! 	  {
! 	  case 'f': case 'F':
! 	    if (fflag)
! 	      ERROR ("more than one 'f' suffix on floating constant");
! 	    else if (warn_traditional && !in_system_header
! 		     && ! cpp_sys_macro_p (parse_in))
! 	      warning ("traditional C rejects the 'f' suffix");
  
! 	    fflag = 1;
! 	    break;
  
! 	  case 'l': case 'L':
! 	    if (lflag)
! 	      ERROR ("more than one 'l' suffix on floating constant");
! 	    else if (warn_traditional && !in_system_header
! 		     && ! cpp_sys_macro_p (parse_in))
! 	      warning ("traditional C rejects the 'l' suffix");
  
! 	    lflag = 1;
! 	    break;
  
! 	  case 'i': case 'I':
! 	  case 'j': case 'J':
! 	    if (imag)
! 	      ERROR ("more than one 'i' or 'j' suffix on floating constant");
! 	    else if (pedantic)
! 	      pedwarn ("ISO C forbids imaginary numeric constants");
! 	    imag = 1;
! 	    break;
  
! 	  default:
! 	    ERROR ("invalid suffix on floating constant");
! 	  }
  
!       type = double_type_node;
!       typename = "double";
! 	
!       if (fflag)
! 	{
! 	  if (lflag)
! 	    ERROR ("both 'f' and 'l' suffixes on floating constant");
  
! 	  type = float_type_node;
! 	  typename = "float";
! 	}
!       else if (lflag)
! 	{
! 	  type = long_double_type_node;
! 	  typename = "long double";
! 	}
!       else if (flag_single_precision_constant)
! 	{
! 	  type = float_type_node;
! 	  typename = "float";
! 	}
  
!       /* Warn about this only after we know we're not issuing an error.  */
!       if (base == 16 && pedantic && !flag_isoc99)
! 	pedwarn ("hexadecimal floating constants are only valid in C99");
  
!       /* The second argument, machine_mode, of REAL_VALUE_ATOF
! 	 tells the desired precision of the binary result
! 	 of decimal-to-binary conversion.  */
!       if (base == 16)
! 	real = REAL_VALUE_HTOF (copy, TYPE_MODE (type));
!       else
! 	real = REAL_VALUE_ATOF (copy, TYPE_MODE (type));
  
!       /* A diagnostic is required here by some ISO C testsuites.
! 	 This is not pedwarn, because some people don't want
! 	 an error for this.  */
!       if (REAL_VALUE_ISINF (real) && pedantic)
! 	warning ("floating point number exceeds range of 'double'");
  
!       /* Create a node with determined type and value.  */
!       if (imag)
! 	value = build_complex (NULL_TREE, convert (type, integer_zero_node),
! 			       build_real (type, real));
!       else
! 	value = build_real (type, real);
!     }
    else
      {
!       tree trad_type, type;
!       HOST_WIDE_INT high, low;
!       int spec_unsigned = 0;
!       int spec_long = 0;
!       int spec_long_long = 0;
!       int spec_imag = 0;
!       int suffix_lu = 0;
!       int warn = 0, i;
  
!       trad_type = type = NULL_TREE;
!       while (p < str + len)
  	{
! 	  c = *p++;
! 	  switch (c)
! 	    {
! 	    case 'u': case 'U':
! 	      if (spec_unsigned)
! 		error ("two 'u' suffixes on integer constant");
! 	      else if (warn_traditional && !in_system_header
! 		       && ! cpp_sys_macro_p (parse_in))
! 		warning ("traditional C rejects the 'u' suffix");
! 
! 	      spec_unsigned = 1;
! 	      if (spec_long)
! 		suffix_lu = 1;
! 	      break;
  
! 	    case 'l': case 'L':
! 	      if (spec_long)
  		{
! 		  if (spec_long_long)
! 		    error ("three 'l' suffixes on integer constant");
! 		  else if (suffix_lu)
! 		    error ("'lul' is not a valid integer suffix");
! 		  else if (c != spec_long)
! 		    error ("'Ll' and 'lL' are not valid integer suffixes");
! 		  else if (pedantic && ! flag_isoc99
! 			   && ! in_system_header && warn_long_long)
! 		    pedwarn ("ISO C89 forbids long long integer constants");
! 		  spec_long_long = 1;
  		}
! 	      spec_long = c;
! 	      break;
! 
! 	    case 'i': case 'I': case 'j': case 'J':
! 	      if (spec_imag)
! 		error ("more than one 'i' or 'j' suffix on integer constant");
! 	      else if (pedantic)
! 		pedwarn ("ISO C forbids imaginary numeric constants");
! 	      spec_imag = 1;
! 	      break;
! 
! 	    default:
! 	      ERROR ("invalid suffix on integer constant");
  	    }
  	}
  
!       /* If the literal overflowed, pedwarn about it now.  */
!       if (overflow)
! 	{
! 	  warn = 1;
! 	  pedwarn ("integer constant is too large for this configuration of the compiler - truncated to %d bits", HOST_BITS_PER_WIDE_INT * 2);
! 	}
! 
!       /* This is simplified by the fact that our constant
! 	 is always positive.  */
  
!       high = low = 0;
  
!       for (i = 0; i < HOST_BITS_PER_WIDE_INT / HOST_BITS_PER_CHAR; i++)
! 	{
! 	  high |= ((HOST_WIDE_INT) parts[i + (HOST_BITS_PER_WIDE_INT
! 					      / HOST_BITS_PER_CHAR)]
! 		   << (i * HOST_BITS_PER_CHAR));
! 	  low |= (HOST_WIDE_INT) parts[i] << (i * HOST_BITS_PER_CHAR);
! 	}
  
!       value = build_int_2 (low, high);
!       TREE_TYPE (value) = long_long_unsigned_type_node;
  
!       /* If warn_traditional, calculate both the ISO type and the
! 	 traditional type, then see if they disagree.  */
!       if (warn_traditional)
! 	{
! 	  /* Traditionally, any constant is signed; but if unsigned is
! 	     specified explicitly, obey that.  Use the smallest size
! 	     with the right number of bits, except for one special
! 	     case with decimal constants.  */
! 	  if (! spec_long && base != 10
! 	      && int_fits_type_p (value, unsigned_type_node))
! 	    trad_type = spec_unsigned ? unsigned_type_node : integer_type_node;
! 	  /* A decimal constant must be long if it does not fit in
! 	     type int.  I think this is independent of whether the
! 	     constant is signed.  */
! 	  else if (! spec_long && base == 10
! 		   && int_fits_type_p (value, integer_type_node))
! 	    trad_type = spec_unsigned ? unsigned_type_node : integer_type_node;
! 	  else if (! spec_long_long)
! 	    trad_type = (spec_unsigned
! 			 ? long_unsigned_type_node
! 			 : long_integer_type_node);
! 	  else if (int_fits_type_p (value,
! 				    spec_unsigned 
! 				    ? long_long_unsigned_type_node
! 				    : long_long_integer_type_node)) 
! 	    trad_type = (spec_unsigned
! 			 ? long_long_unsigned_type_node
! 			 : long_long_integer_type_node);
! 	  else
! 	    trad_type = (spec_unsigned
! 			 ? widest_unsigned_literal_type_node
! 			 : widest_integer_literal_type_node);
! 	}
! 	
! 	/* Calculate the ISO type.  */
! 	if (! spec_long && ! spec_unsigned
! 	    && int_fits_type_p (value, integer_type_node))
! 	  type = integer_type_node;
! 	else if (! spec_long && (base != 10 || spec_unsigned)
! 		 && int_fits_type_p (value, unsigned_type_node))
! 	  type = unsigned_type_node;
! 	else if (! spec_unsigned && !spec_long_long
! 		 && int_fits_type_p (value, long_integer_type_node))
! 	  type = long_integer_type_node;
! 	else if (! spec_long_long
! 		 && int_fits_type_p (value, long_unsigned_type_node))
! 	  type = long_unsigned_type_node;
! 	else if (! spec_unsigned
! 		 && int_fits_type_p (value, long_long_integer_type_node))
! 	  type = long_long_integer_type_node;
! 	else if (int_fits_type_p (value, long_long_unsigned_type_node))
! 	  type = long_long_unsigned_type_node;
! 	else if (! spec_unsigned
! 		 && int_fits_type_p (value, widest_integer_literal_type_node))
! 	  type = widest_integer_literal_type_node;
! 	else
! 	  type = widest_unsigned_literal_type_node;
  
!       /* We assume that constants specified in a non-decimal
! 	 base are bit patterns, and that the programmer really
! 	 meant what they wrote.  */
!       if (warn_traditional && !in_system_header
! 	  && base == 10 && trad_type != type)
! 	{
! 	  if (TYPE_PRECISION (trad_type) != TYPE_PRECISION (type))
! 	    warning ("width of integer constant is different in traditional C");
! 	  else if (TREE_UNSIGNED (trad_type) != TREE_UNSIGNED (type))
! 	    warning ("integer constant is unsigned in ISO C, signed in traditional C");
! 	  else
! 	    warning ("width of integer constant may change on other systems in traditional C");
! 	}
  
!       if (pedantic && (flag_isoc99 || !spec_long_long)
! 	  && !warn
! 	  && ((flag_isoc99
! 	       ? TYPE_PRECISION (long_long_integer_type_node)
! 	       : TYPE_PRECISION (long_integer_type_node)) < TYPE_PRECISION (type)))
! 	{
! 	  warn = 1;
! 	  pedwarn ("integer constant larger than the maximum value of %s",
! 		   (flag_isoc99
! 		    ? (TREE_UNSIGNED (type)
! 		       ? _("an unsigned long long int")
! 		       : _("a long long int"))
! 		    : _("an unsigned long int")));
! 	}
  
!       if (base == 10 && ! spec_unsigned && TREE_UNSIGNED (type))
! 	warning ("decimal constant is so large that it is unsigned");
  
!       if (spec_imag)
! 	{
! 	  if (TYPE_PRECISION (type)
! 	      <= TYPE_PRECISION (integer_type_node))
! 	    value = build_complex (NULL_TREE, integer_zero_node,
! 				   convert (integer_type_node, value));
! 	  else
! 	    ERROR ("complex integer constant is too wide for 'complex int'");
! 	}
!       else
! 	TREE_TYPE (value) = type;
  
!       /* If it's still an integer (not a complex), and it doesn't
! 	 fit in the type we choose for it, then pedwarn.  */
  
!       if (! warn
! 	  && TREE_CODE (TREE_TYPE (value)) == INTEGER_TYPE
! 	  && ! int_fits_type_p (value, TREE_TYPE (value)))
! 	pedwarn ("integer constant is larger than the maximum value for its type");
!     }
  
!   if (p < str + len)
!     error ("missing white space after number '%.*s'", (int) (p - str), str);
  
    return value;
- 
-  syntax_error:
-   return integer_zero_node;
  }
  
  static tree
--- 750,957 ----
    return tok->type;
  }
  
! /* Returns the narrowest C-visible unsigned type, starting with the
!    minimum specified by FLAGS, that can fit VALUE, or itk_none if
!    there isn't one.  */
! static enum integer_type_kind
! narrowest_unsigned_type (value, flags)
!      tree value;
!      unsigned int flags;
  {
!   enum integer_type_kind itk;
  
!   if ((flags & CPP_N_WIDTH) == CPP_N_SMALL)
!     itk = itk_unsigned_int;
!   else if ((flags & CPP_N_WIDTH) == CPP_N_MEDIUM)
!     itk = itk_unsigned_long;
!   else
!     itk = itk_unsigned_long_long;
  
!   /* int_fits_type_p must think the type of its first argument is
!      wider than its second argument, or it won't do the proper check.  */
!   TREE_TYPE (value) = widest_unsigned_literal_type_node;
  
!   for (; itk < itk_none; itk += 2 /* skip unsigned types */)
!     if (int_fits_type_p (value, integer_types[itk]))
!       return itk;
  
!   return itk_none;
! }
  
! /* Ditto, but narrowest signed type.  */
! static enum integer_type_kind
! narrowest_signed_type (value, flags)
!      tree value;
!      unsigned int flags;
! {
!   enum integer_type_kind itk;
  
!   if ((flags & CPP_N_WIDTH) == CPP_N_SMALL)
!     itk = itk_int;
!   else if ((flags & CPP_N_WIDTH) == CPP_N_MEDIUM)
!     itk = itk_long;
!   else
!     itk = itk_long_long;
  
!   /* int_fits_type_p must think the type of its first argument is
!      wider than its second argument, or it won't do the proper check.  */
!   TREE_TYPE (value) = widest_unsigned_literal_type_node;
  
!   for (; itk < itk_none; itk += 2 /* skip signed types */)
!     if (int_fits_type_p (value, integer_types[itk]))
!       return itk;
  
!   return itk_none;
! }
  
! /* Interpret TOKEN, an integer with FLAGS as classified by cpplib.  */
! static tree
! interpret_integer (token, flags)
!      const cpp_token *token;
!      unsigned int flags;
! {
!   tree value, type;
!   enum integer_type_kind itk;
!   cpp_num integer;
!   cpp_options *options = cpp_get_options (parse_in);
  
!   integer = cpp_interpret_integer (parse_in, token, flags);
!   integer = cpp_num_sign_extend (integer, options->precision);
!   value = build_int_2_wide (integer.low, integer.high);
  
!   /* The type of a constant with a U suffix is straightforward.  */
!   if (flags & CPP_N_UNSIGNED)
!     itk = narrowest_unsigned_type (value, flags);
    else
      {
!       /* The type of a potentially-signed integer constant varies
! 	 depending on the base it's in, the standard in use, and the
! 	 length suffixes.  */
!       enum integer_type_kind itk_u = narrowest_unsigned_type (value, flags);
!       enum integer_type_kind itk_s = narrowest_signed_type (value, flags);
  
!       /* In both C89 and C99, octal and hex constants may be signed or
! 	 unsigned, whichever fits tighter.  We do not warn about this
! 	 choice differing from the traditional choice, as the constant
! 	 is probably a bit pattern and either way will work.  */
!       if ((flags & CPP_N_RADIX) != CPP_N_DECIMAL)
! 	itk = MIN (itk_u, itk_s);
!       else
  	{
! 	  /* In C99, decimal constants are always signed.
! 	     In C89, decimal constants that don't fit in long have
! 	     undefined behaviour; we try to make them unsigned long.
! 	     In GCC's extended C89, that last is true of decimal
! 	     constants that don't fit in long long, too.  */
  
! 	  itk = itk_s;
! 	  if (itk_s > itk_u && itk_s > itk_long)
! 	    {
! 	      if (!flag_isoc99)
  		{
! 		  if (itk_u < itk_unsigned_long)
! 		    itk_u = itk_unsigned_long;
! 		  itk = itk_u;
! 		  warning ("this decimal constant is unsigned only in ISO C89");
  		}
! 	      else if (warn_traditional)
! 		warning ("this decimal constant would be unsigned in ISO C89");
  	    }
  	}
+     }
  
!   if (itk == itk_none)
!     /* cpplib has already issued a warning for overflow.  */
!     type = ((flags & CPP_N_UNSIGNED)
! 	    ? widest_unsigned_literal_type_node
! 	    : widest_integer_literal_type_node);
!   else
!     type = integer_types[itk];
  
!   if (itk > itk_unsigned_long
!       && (flags & CPP_N_WIDTH) != CPP_N_LARGE
!       && ! in_system_header && ! flag_isoc99)
!     pedwarn ("integer constant is too large for \"%s\" type",
! 	     (flags & CPP_N_UNSIGNED) ? "unsigned long" : "long");
  
!   TREE_TYPE (value) = type;
  
!   /* Convert imaginary to a complex type.  */
!   if (flags & CPP_N_IMAGINARY)
!     value = build_complex (NULL_TREE, convert (type, integer_zero_node), value);
  
!   return value;
! }
  
! /* Interpret TOKEN, a floating point number with FLAGS as classified
!    by cpplib.  */
! static tree
! interpret_float (token, flags)
!      const cpp_token *token;
!      unsigned int flags;
! {
!   tree type;
!   tree value;
!   REAL_VALUE_TYPE real;
!   char *copy;
!   size_t copylen;
!   const char *typename;
  
!   /* FIXME: make %T work in error/warning, then we don't need typename.  */
!   if ((flags & CPP_N_WIDTH) == CPP_N_LARGE)
!     {
!       type = long_double_type_node;
!       typename = "long double";
!     }
!   else if ((flags & CPP_N_WIDTH) == CPP_N_SMALL
! 	   || flag_single_precision_constant)
!     {
!       type = float_type_node;
!       typename = "float";
!     }
!   else
!     {
!       type = double_type_node;
!       typename = "double";
!     }
  
!   /* Copy the constant to a nul-terminated buffer.  If the constant
!      has any suffixes, cut them off; REAL_VALUE_ATOF/ REAL_VALUE_HTOF
!      can't handle them.  */
!   copylen = token->val.str.len;
!   if ((flags & CPP_N_WIDTH) != CPP_N_MEDIUM)
!     /* Must be an F or L suffix.  */
!     copylen--;
!   if (flags & CPP_N_IMAGINARY)
!     /* I or J suffix.  */
!     copylen--;
  
!   copy = alloca (copylen + 1);
!   memcpy (copy, token->val.str.text, copylen);
!   copy[copylen] = '\0';
  
!   /* The second argument, machine_mode, of REAL_VALUE_ATOF tells the
!      desired precision of the binary result of decimal-to-binary
!      conversion.  */
!   if (flags & CPP_N_HEX)
!     real = REAL_VALUE_HTOF (copy, TYPE_MODE (type));
!   else
!     real = REAL_VALUE_ATOF (copy, TYPE_MODE (type));
  
!   /* A diagnostic is required for "soft" overflow by some ISO C
!      testsuites.  This is not pedwarn, because some people don't want
!      an error for this.
!      ??? That's a dubious reason... is this a mandatory diagnostic or
!      isn't it?   -- zw, 2001-08-21.  */
!   if (REAL_VALUE_ISINF (real) && pedantic)
!     warning ("floating constant exceeds range of \"%s\"", typename);
  
!   /* Create a node with determined type and value.  */
!   value = build_real (type, real);
!   if (flags & CPP_N_IMAGINARY)
!     value = build_complex (NULL_TREE, convert (type, integer_zero_node), value);
  
    return value;
  }
  
  static tree
*************** lex_charconst (token)
*** 1321,1327 ****
    tree type, value;
    unsigned int chars_seen;
    int unsignedp;
!  
    result = cpp_interpret_charconst (parse_in, token,
   				    &chars_seen, &unsignedp);
  
--- 1065,1071 ----
    tree type, value;
    unsigned int chars_seen;
    int unsignedp;
! 
    result = cpp_interpret_charconst (parse_in, token,
   				    &chars_seen, &unsignedp);
  
============================================================
Index: gcc/cpperror.c
*** gcc/cpperror.c	23 May 2002 06:07:43 -0000	1.59
--- gcc/cpperror.c	2 Jun 2002 09:25:25 -0000
*************** _cpp_begin_message (pfile, code, line, c
*** 92,97 ****
--- 92,98 ----
  	{
  	  if (CPP_OPTION (pfile, inhibit_errors))
  	    return 0;
+ 	  level = DL_ERROR;
  	  pfile->errors++;
  	}
        else if (CPP_OPTION (pfile, inhibit_warnings))
============================================================
Index: gcc/cppexp.c
*** gcc/cppexp.c	1 Jun 2002 14:11:45 -0000	1.121
--- gcc/cppexp.c	2 Jun 2002 09:25:26 -0000
*************** num_positive (num, precision)
*** 995,1000 ****
--- 995,1027 ----
    return (num.low & (cpp_num_part) 1 << (precision - 1)) == 0;
  }
  
+ /* Sign extend a number, with PRECISION significant bits and all
+    others assumed clear, to fill out a cpp_num structure.  */
+ cpp_num
+ cpp_num_sign_extend (num, precision)
+      cpp_num num;
+      size_t precision;
+ {
+   if (!num.unsignedp)
+     {
+       if (precision > PART_PRECISION)
+ 	{
+ 	  precision -= PART_PRECISION;
+ 	  if (precision < PART_PRECISION
+ 	      && (num.high & (cpp_num_part) 1 << (precision - 1)))
+ 	    num.high |= ~(~(cpp_num_part) 0 >> (PART_PRECISION - precision));
+ 	}
+       else if (num.low & (cpp_num_part) 1 << (precision - 1))
+ 	{
+ 	  if (precision < PART_PRECISION)
+ 	    num.low |= ~(~(cpp_num_part) 0 >> (PART_PRECISION - precision));
+ 	  num.high = ~(cpp_num_part) 0;
+ 	}
+     }
+ 
+   return num;
+ }
+ 
  /* Returns the negative of NUM.  */
  static cpp_num
  num_negate (num, precision)
============================================================
Index: gcc/cppinit.c
*** gcc/cppinit.c	31 May 2002 22:57:55 -0000	1.236
--- gcc/cppinit.c	2 Jun 2002 09:25:26 -0000
*************** cpp_post_options (pfile)
*** 1770,1775 ****
--- 1770,1777 ----
    if (CPP_OPTION (pfile, cplusplus))
      CPP_OPTION (pfile, warn_traditional) = 0;
  
+   /* The compiler front ends override this, but I think this is the
+      appropriate setting for the library.  */
    CPP_OPTION (pfile, warn_long_long) = (CPP_OPTION (pfile, pedantic)
  					&& !CPP_OPTION (pfile, c99));
  
============================================================
Index: gcc/cpplib.h
*** gcc/cpplib.h	29 May 2002 17:15:32 -0000	1.221
--- gcc/cpplib.h	2 Jun 2002 09:25:27 -0000
*************** extern unsigned cpp_classify_number PARA
*** 625,630 ****
--- 625,634 ----
  extern cpp_num cpp_interpret_integer PARAMS ((cpp_reader *, const cpp_token *,
  					      unsigned int type));
  
+ /* Sign extend a number, with PRECISION significant bits and all
+    others assumed clear, to fill out a cpp_num structure.  */
+ cpp_num cpp_num_sign_extend PARAMS ((cpp_num, size_t));
+ 
  /* Diagnostic levels.  To get a dianostic without associating a
     position in the translation unit with it, use cpp_error_with_line
     with a line number of zero.  */
============================================================
Index: gcc/tree.h
*** gcc/tree.h	1 Jun 2002 16:56:07 -0000	1.340
--- gcc/tree.h	2 Jun 2002 09:25:28 -0000
*************** extern tree global_trees[TI_MAX];
*** 2027,2033 ****
  #define V16SF_type_node			global_trees[TI_V16SF_TYPE]
  
  /* An enumeration of the standard C integer types.  These must be
!    ordered so that shorter types appear before longer ones.  */
  enum integer_type_kind
  {
    itk_char,
--- 2027,2035 ----
  #define V16SF_type_node			global_trees[TI_V16SF_TYPE]
  
  /* An enumeration of the standard C integer types.  These must be
!    ordered so that shorter types appear before longer ones, and so
!    that signed types appear before unsigned ones, for the correct
!    functioning of interpret_integer() in c-lex.c.  */
  enum integer_type_kind
  {
    itk_char,
============================================================
Index: gcc/testsuite/gcc.dg/c99-intconst-1.c
*** gcc/testsuite/gcc.dg/c99-intconst-1.c	23 Jan 2002 18:12:37 -0000	1.2
--- gcc/testsuite/gcc.dg/c99-intconst-1.c	2 Jun 2002 09:25:28 -0000
***************
*** 4,14 ****
  /* { dg-do compile } */
  /* { dg-options "-std=iso9899:1999 -pedantic-errors" } */
  
- /* C99 type selection didn't make it into 3.1, so this test
-    will fail on one or two entries; which ones depends on the
-    platform.
-    { dg-excess-errors "c99 not yet" } */
- 
  #include <limits.h>
  
  /* Assertion that constant C is of type T.  */
--- 4,9 ----
============================================================
Index: gcc/testsuite/gcc.dg/wtr-int-type-1.c
*** gcc/testsuite/gcc.dg/wtr-int-type-1.c	7 Dec 2000 23:21:09 -0000	1.4
--- gcc/testsuite/gcc.dg/wtr-int-type-1.c	2 Jun 2002 09:25:28 -0000
***************
*** 2,8 ****
     Note, gcc should omit these warnings in system header files.
     By Kaveh R. Ghazi <ghazi@caip.rutgers.edu> 8/22/2000.  */
  /* { dg-do compile } */
! /* { dg-options "-Wtraditional" } */
  
  void
  testfunc (void)
--- 2,8 ----
     Note, gcc should omit these warnings in system header files.
     By Kaveh R. Ghazi <ghazi@caip.rutgers.edu> 8/22/2000.  */
  /* { dg-do compile } */
! /* { dg-options "-std=c99 -Wtraditional" } */
  
  void
  testfunc (void)
*************** testfunc (void)
*** 18,29 ****
    i = 0xFFFFFFFFFFFFFFFF;
    i = 01777777777777777777777;
  
!   /* We expect to get either a "width of integer constant changes with
!      -traditional" warning or an "integer constant is unsigned in ISO
!      C, signed with -traditional" warning depending on whether we are
!      testing on a 32 or 64 bit platform.  Either warning means the
!      test passes and both matched by checking for "integer constant".  */
!   i = 18446744073709551615; /* { dg-warning "integer constant" "integer constant" } */
    
  # 29 "sys-header.h" 3
  /* We are in system headers now, no -Wtraditional warnings should issue.  */
--- 18,31 ----
    i = 0xFFFFFFFFFFFFFFFF;
    i = 01777777777777777777777;
  
!   /* Nor should values outside the range of (32-bit) unsigned long but
!      inside the range of long long.  [since -traditional has no long long,
!      we can pretend it worked the way it does in C99.]  */
!   i = 9223372036854775807;
! 
!   /* But this one should, since it doesn't fit in long (long), but
!      does fit in unsigned long (long).  */
!   i = 18446744073709551615; /* { dg-warning "decimal constant|unsigned" "decimal constant" } */
    
  # 29 "sys-header.h" 3
  /* We are in system headers now, no -Wtraditional warnings should issue.  */
*************** testfunc (void)
*** 39,44 ****
    i = 9223372036854775807;
    i = 18446744073709551615;
  }
- 
- /* Ignore "decimal constant is so large that it is unsigned" warnings.  */
- /* { dg-warning "decimal constant" "decimal constant" { target *-*-* } 26 } */
--- 41,43 ----
============================================================
Index: gcc/testsuite/gcc.dg/wtr-suffix-1.c
*** gcc/testsuite/gcc.dg/wtr-suffix-1.c	7 Dec 2000 23:21:09 -0000	1.3
--- gcc/testsuite/gcc.dg/wtr-suffix-1.c	2 Jun 2002 09:25:28 -0000
*************** testfunc (void)
*** 12,24 ****
  
    i = 1L;
    i = 1l;
!   i = 1U; /* { dg-warning "traditional C rejects the 'u' suffix" "numeric constant suffix" } */
!   i = 1u; /* { dg-warning "traditional C rejects the 'u' suffix" "numeric constant suffix" } */
    f = 1.0;
!   f = 1.0F; /* { dg-warning "traditional C rejects the 'f' suffix" "numeric constant suffix" } */
!   f = 1.0f; /* { dg-warning "traditional C rejects the 'f' suffix" "numeric constant suffix" } */
!   f = 1.0L; /* { dg-warning "traditional C rejects the 'l' suffix" "numeric constant suffix" } */
!   f = 1.0l; /* { dg-warning "traditional C rejects the 'l' suffix" "numeric constant suffix" } */
   
  # 24 "sys-header.h" 3
  /* We are in system headers now, no -Wtraditional warnings should issue.  */
--- 12,24 ----
  
    i = 1L;
    i = 1l;
!   i = 1U; /* { dg-warning "traditional C rejects" "numeric constant suffix" } */
!   i = 1u; /* { dg-warning "traditional C rejects" "numeric constant suffix" } */
    f = 1.0;
!   f = 1.0F; /* { dg-warning "traditional C rejects" "numeric constant suffix" } */
!   f = 1.0f; /* { dg-warning "traditional C rejects" "numeric constant suffix" } */
!   f = 1.0L; /* { dg-warning "traditional C rejects" "numeric constant suffix" } */
!   f = 1.0l; /* { dg-warning "traditional C rejects" "numeric constant suffix" } */
   
  # 24 "sys-header.h" 3
  /* We are in system headers now, no -Wtraditional warnings should issue.  */
============================================================
Index: gcc/testsuite/gcc.dg/cpp/paste4.c
*** gcc/testsuite/gcc.dg/cpp/paste4.c	31 Jan 2001 07:50:11 -0000	1.2
--- gcc/testsuite/gcc.dg/cpp/paste4.c	2 Jun 2002 09:25:28 -0000
***************
*** 11,16 ****
  
  int main ()
  {
!   double d = glue (1.0e, +1); /* { dg-error "floating const|parse error" } */
    return 0;
  }
--- 11,16 ----
  
  int main ()
  {
!   double d = glue (1.0e, +1); /* { dg-error "exponent|parse error" } */
    return 0;
  }
============================================================
Index: gcc/testsuite/gcc.dg/cpp/sysmac2.c
*** gcc/testsuite/gcc.dg/cpp/sysmac2.c	6 May 2001 09:48:28 -0000	1.3
--- gcc/testsuite/gcc.dg/cpp/sysmac2.c	2 Jun 2002 09:25:28 -0000
***************
*** 1,7 ****
  /* Copyright (C) 2001 Free Software Foundation, Inc.  */
  
  /* { dg-do compile } */
! /* { dg-options "-std=gnu99 -pedantic -Wtraditional" } */
  
  /* Tests diagnostics are suppressed for some macros defined in system
     headers.  */
--- 1,7 ----
  /* Copyright (C) 2001 Free Software Foundation, Inc.  */
  
  /* { dg-do compile } */
! /* { dg-options "-std=gnu99 -pedantic -Wtraditional -fno-show-column" } */
  
  /* Tests diagnostics are suppressed for some macros defined in system
     headers.  */



More information about the Gcc-patches mailing list