typedef-named class member functions can be public

Joseph S. Myers jsm28@cam.ac.uk
Fri Jul 5 14:18:00 GMT 2002


On Fri, 5 Jul 2002, Mark Mitchell wrote:

> However, our policy is not to accept patches without testcases.  The
> test case should fail without the patch and pass with the patch.

contribute.html says

   Testcases
          If you cannot follow the recommendations of the GCC coding
          conventions about testcases, you should include a justification
          for why adequate testcases cannot be added.

The justification might be "test is in a proprietary testsuite" (as here),
it might be "test is large and proprietary and for some intrinsic reason a
small testcase won't work to test the problem", it might be "the dejagnu
framework doesn't support testing for this type of problem".  (But it
shouldn't be "test is large and proprietary and I don't want to put in the
effort to create a small testcase", and it shouldn't be "I'll do the 
code now, and the docs and testcases later" (since something might 
intervene that stops the "later" from getting done).)

-- 
Joseph S. Myers
jsm28@cam.ac.uk



More information about the Gcc-patches mailing list