SH: Reloc overflow

Alexandre Oliva aoliva@redhat.com
Sun Jan 20 15:47:00 GMT 2002


On Jan 20, 2002, Joern Rennecke <amylaar@onetel.net.uk> wrote:

>> I don't know if there are more cases like this in sh.md.

> branch-around-32-bit-jump will ahve the same issues.

>> * config/sh/sh.md: Conditional branches have a worst case length
>> of 16, not 12.	

> Actually, condbranches already have a worst case length of 16 even without
> the suprious delay slot insns.  For the condbranch-around-32-bit-jump
> case.

Since you seem to have a good understanding of that chunk of code (I
suppose you wrote it), would you mind documenting the reasons for the
jump lengths next to the implementation?  Then someone else in need of
fixing problems there does not have to go scratching heads and trying
to recreate the thoughts of whoever wrote that piece of code.  Such
duplication of effort is not only a waste of effort, but also very
error prone, as you have just demonstrated :-)

Thanks,

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me



More information about the Gcc-patches mailing list