new macro STARTING_FRAME_PHASE: alignment

Geoff Keating geoffk@geoffk.org
Sun Jan 20 15:25:00 GMT 2002


Aldy Hernandez <aldyh@redhat.com> writes:

> On Sat, Jan 19, 2002 at 10:55:58PM -0800, Geoff Keating wrote:
> > Aldy Hernandez <aldyh@redhat.com> writes:
> > 
> > > #define STARTING_FRAME_PHASE (TARGET_32BIT && !TARGET_AIX ? 8 : 0)
> > 
> > I think you probably want TARGET_ALTIVEC_ABI rather than
> > !TARGET_AIX; the STACK_BOUNDARY will only be 64 in those cases.
> 
> i thought the ppc sysv4 stack was supposed to be 128byte aligned as
> well.  but certainly, having TARGET_ALTIVEC_ABI will affect the least
> amount of folks.
> 
> david, geoff, what do you prefer?

It's not a question of preference, this has to match what
STACK_BOUNDARY says.

In fact, you could

#define STARTING_FRAME_PHASE \
  ((RS6000_VARARGS_AREA + RS6000_SAVE_AREA) \
   & ((1 << STACK_BOUNDARY-BITS_PER_UNIT)-1))

which might be the best idea.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>



More information about the Gcc-patches mailing list