Jump threading fix II

H . J . Lu hjl@lucon.org
Sun Jan 6 20:40:00 GMT 2002


On Sun, Jan 06, 2002 at 08:10:05PM +0100, Jan Hubicka wrote:
> > On Sun, Jan 06, 2002 at 07:55:22PM +0100, Jan Hubicka wrote:
> > > This should be OK - the code1 is always reversed in order to be true to
> > > get into the block and code2 is kept in the original form.
> > > WHen choosing the outgoing edges I need to check whether code2 dominates
> > > and choose else or if version of it.
> > > 
> > > There has been the typo in operand number.  Now I am getting bootstrap
> > > failure, but it is unrelated to threading - even if I disable it it fails.
> > > Other emails seems to suggest that the unrelated problem has been fixed.
> > > > 
> > > > http://gcc.gnu.org/ml/gcc-patches/2001-12/msg01658.html
> > > > 
> > > > line by line and convince yourself they are 100% correct?
> > > 
> > > I did that about 3 times - thats why I sent the fixes to hypotetical
> > > bugs (such as hard regnos etc).  The MIPS bug has been the typo/thinko
> > > at very end of thread_jump.
> > > 
> > > Are you still having problems today?
> > > Hope not :)
> > 
> > I am testing
> > 
> > http://gcc.gnu.org/ml/gcc-patches/2002-01/msg00357.html
> 
> > 
> > It seems very promising. I am running "make check" on Sat Jan  5
> > 09:51:17 PST 2002 with it on Linux/mips now. I also bootstraped Dec 17
> > 09:30 PST 2001 with it and your fixes on mips-sgi-irix6.5.
> > 
> 
> It is really obvious fix.  Thanks for catching that and I apologize for
> the problems caused :(

I tested it on Linux/mipel:

http://gcc.gnu.org/ml/gcc-testresults/2002-01/msg00096.html

I also bootstraped it on mips-sgi-irix6.5. There are no regressions on
Linux/i686. I am checking it in now.

Thanks.


H.J.



More information about the Gcc-patches mailing list