Jump threading fix II
Jan Hubicka
jh@suse.cz
Sun Jan 6 11:14:00 GMT 2002
> On Sun, Jan 06, 2002 at 07:55:22PM +0100, Jan Hubicka wrote:
> > This should be OK - the code1 is always reversed in order to be true to
> > get into the block and code2 is kept in the original form.
> > WHen choosing the outgoing edges I need to check whether code2 dominates
> > and choose else or if version of it.
> >
> > There has been the typo in operand number. Now I am getting bootstrap
> > failure, but it is unrelated to threading - even if I disable it it fails.
> > Other emails seems to suggest that the unrelated problem has been fixed.
> > >
> > > http://gcc.gnu.org/ml/gcc-patches/2001-12/msg01658.html
> > >
> > > line by line and convince yourself they are 100% correct?
> >
> > I did that about 3 times - thats why I sent the fixes to hypotetical
> > bugs (such as hard regnos etc). The MIPS bug has been the typo/thinko
> > at very end of thread_jump.
> >
> > Are you still having problems today?
> > Hope not :)
>
> I am testing
>
> http://gcc.gnu.org/ml/gcc-patches/2002-01/msg00357.html
>
> It seems very promising. I am running "make check" on Sat Jan 5
> 09:51:17 PST 2002 with it on Linux/mips now. I also bootstraped Dec 17
> 09:30 PST 2001 with it and your fixes on mips-sgi-irix6.5.
>
It is really obvious fix. Thanks for catching that and I apologize for
the problems caused :(
MIPS is one of few "main" targets excercising code in question. It still looks
like a bug in MIPS md file that the conditionals are not reversable. I am just
checking MIPS instruction set manual if there is good purpose for this to
happen.
Honza
More information about the Gcc-patches
mailing list