none

Andreas Jaeger aj@suse.de
Fri Jan 4 10:42:00 GMT 2002


law@redhat.com writes:

> Your recent patch to toplev.c is causing regressions on the x86.  
> Specifically the compiler is hanging in c-torture on 
> compile/941014-3.c -fomit-frame-pointer -funroll-all-loops -finline-functions
>
> Please investigate and fix:
>
> 2002-01-04  H.J. Lu <hjl@gnu.org>
>
>         * toplev.c (rest_of_compilation): Fix a typo when calling
>         cleanup_cfg.

In that case we have a latent bug.  I build the testsuite on x86
without problems (but have store motion disabled).

I'm appending the patch again, it's really obvious IMO and I expect
the problem to be somewhere else.

Honza, do you have any idea?

Andreas


Index: toplev.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/toplev.c,v
retrieving revision 1.564
retrieving revision 1.565
diff -u -r1.564 -r1.565
--- toplev.c	2001/12/27 17:22:00	1.564
+++ toplev.c	2002/01/04 05:41:24	1.565
@@ -1,6 +1,6 @@
 /* Top level of GNU C compiler
    Copyright (C) 1987, 1988, 1989, 1992, 1993, 1994, 1995, 1996, 1997, 1998,
-   1999, 2000, 2001 Free Software Foundation, Inc.
+   1999, 2000, 2001, 2002 Free Software Foundation, Inc.
 
 This file is part of GCC.
 
@@ -2941,7 +2941,7 @@
   open_dump_file (DFI_cfg, decl);
 
   find_basic_blocks (insns, max_reg_num (), rtl_dump_file);
-  cleanup_cfg (optimize ? CLEANUP_EXPENSIVE : 0
+  cleanup_cfg ((optimize ? CLEANUP_EXPENSIVE : 0)
 	       | (flag_thread_jumps ? CLEANUP_THREADING : 0));
   check_function_return_warnings ();
 


-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj



More information about the Gcc-patches mailing list