powerpc patch 2 of 9
Zack Weinberg
zack@codesourcery.com
Thu Feb 21 00:17:00 GMT 2002
On Wed, Feb 20, 2002 at 09:52:56PM -0500, David Edelsohn wrote:
> (RETURN_IN_MEMORY): Use HOST_WIDE_INT, not HOST_WIDEST_INT.
>
> This change is incorrect. Zack used HOST_WIDEST_INT on purpose. See
>
> http://gcc.gnu.org/ml/gcc-patches/2001-12/msg00126.html
Actually, the important property of that cast is that it's to an
unsigned type, not that it's to HOST_WIDEST_INT. We want a -1
return from int_size_in_bytes to cause RETURN_IN_MEMORY to be true.
Since int_size_in_bytes returns signed HOST_WIDE_INT, it should be
safe to use unsigned HOST_WIDE_INT.
I don't remember why I used unsigned HOST_WIDEST_INT. I think I
might have misread the code and thought that int_size_in_bytes
returned signed HOST_WIDEST_INT.
zw
More information about the Gcc-patches
mailing list