Patch to provide a default for ASM_OUTPUT_INTERNAL_LABEL
Richard Henderson
rth@redhat.com
Sat Aug 31 10:38:00 GMT 2002
On Sat, Aug 31, 2002 at 09:39:37AM -0400, Kaveh R. Ghazi wrote:
> > I don't see that using alloca here is effective at all.
>
> Why not? I've seen buffers used in dwarf2out.c hardcoded at 20 bytes.
> So 40 + strlen (PREFIX) should be plenty, no?
Yeah, but so would a constant 64.
> I think snprintf is supposed to return the length of what would have
> been output even when you would have exceeded the max, not -1.
Hum. I was just going by what the Linux man page sez.
> Not all platforms do this correctly though, on irix6.5 it returns the
> truncated printed length. So you'll never know that you would have
> exceeded the supplied length by checking the return type.
Blah. Perhaps an argument for using the libiberty snprintf
in that case?
r~
More information about the Gcc-patches
mailing list