Optimizer questions/issues with EBCDIC i370/s390 modes.

Dave Pitts dpitts@cozx.com
Thu Aug 22 08:45:00 GMT 2002


Kaveh R. Ghazi wrote:

> > From: Dave Pitts <dpitts@cozx.com>
> > 
> > Oops, had the files backwards. Here's the correct patch:
> > 
> > --- c-common.c.orig     Wed Aug 21 15:17:02 2002
> > +++ c-common.c  Thu Aug 22 09:03:34 2002
> > @@ -3924,6 +3924,14 @@ c_expand_builtin_printf (arglist, target
> >           /* Given printf("c"), (where c is any one character,)
> >               convert "c"[0] to an int and pass that to the replacement
> >               function.  */
> > +#ifdef MAP_OUTCHAR
> > +         {
> > +           unsigned x = MAP_OUTCHAR(TREE_STRING_POINTER 
> > (stripped_string)[0]);
> > +           arglist = build_int_2 (x, 0);
> > +         }
> > +#else
> > +         arglist = build_int_2 (TREE_STRING_POINTER 
> > (stripped_string)[0], 0);
> > +#endif
> >           arglist = build_int_2 (TREE_STRING_POINTER 
> > (stripped_string)[0], 0);
>
>Shouldn't you remove this last line here?  Did you test it?
>(I think it overwrites your MAP_OUTCHAR case.)
>
>--
>Kaveh R. Ghazi			Director of Systems Architecture
>ghazi@caip.rutgers.edu		Qwest Solutions
>
>
You are correct it needs to be deleted.  I did test it and it worked. 
Strange.

-- 
Dave Pitts                   PULLMAN: Travel and sleep in safety and comfort.
dpitts@cozx.com              My other RV IS a Pullman (Colorado Pine). 
http://www.cozx.com/~dpitts





More information about the Gcc-patches mailing list