[PATCH] gcse global variables removal
Zdenek Dvorak
rakdver@atrey.karlin.mff.cuni.cz
Thu Aug 1 11:53:00 GMT 2002
Hello,
Concerning:
> > > ! struct hash_table
> > > ! {
> > > ! /* The table itself.
> > > ! This is an array of `expr_hash_table_size' elements. */
> > > ! struct expr **table;
> > > !
> > > ! /* Size of the hash table, in elements. */
> > > ! unsigned int size;
> > > !
> > > ! /* Number of hash table elements. */
> > > ! unsigned int n_elems;
> > > !
> > > ! /* Whether the table is expression of copy propagation one. */
> > > ! int set_p;
> > > ! };
> >
> > I don't like including set_p here. The rest of this is
> > directly related to the hash table as an abstract data
> > structure. If we keep set_p separate, then it should be
> > relatively easy to replace this bare hash table widgetry
> > here with hashtab.h bits.
> >
> > The rest of this will be fine, I think. Just need to
> > keep the set_p argument to the various function separate.
>
> I disagree with this -- these are two different structures,
> using different functions to access them, keeping different data
> (just having simmilar internal structure, so that a few functions
> can handle both of them). I thing set_p flag should be a member
> of this structure; this does not prevent us at all to implement
> the rest of the structure in any other way.
>
> Zdenke
I will commit it as it is so that I'm able to move things forward a bit
(the change proposed by Richard changes no functionality, and if he
persuades me that his opinion is right and my wrong, it can be changed
easily).
Zdenek
More information about the Gcc-patches
mailing list