Patch for tail recursion when POINTERS_EXTEND_UNSIGNED is set

Hans-Peter Nilsson hp@bitrange.com
Fri Apr 5 12:07:00 GMT 2002


On Fri, 5 Apr 2002, Steve Ellcey wrote:

> This is a fix for a bug I found while compiling the SPEC GCC program on
> HP-UX IA64.  It could affect other 32/64 bit compilers that set
> POINTERS_EXTEND_UNSIGNED.
>
> Could someone review it and check it in if acceptable?  Tested on HP-UX
> IA64.

Ok, I'll be someone just this once, reviewing the nit part of
it.

> 2002-04-05  Steve Ellcey  <sje@cup.hp.com>
> 	* gcc/stmt.c (tail_recursion_args):  By not calling promote_mode
> 	to (possibly) modify unsignedp before calling convert_move we
> 	could be doing the wrong type of conversion on REFERENCE_TYPE or
> 	POINTER_TYPE arguments when POINTERS_EXTEND_UNSIGNED is set.

Put this in a comment at the (currently comment-free) code, and
change the ChangeLog entry to "Call promote_mode to update
unsignedp before convert_move call".  Rationale: GNU coding
standards: ChangeLog is what, comment in code is why.

brgds, H-P




More information about the Gcc-patches mailing list