Patch to add ACONCAT macro to libiberty

DJ Delorie dj@redhat.com
Tue Sep 18 10:07:00 GMT 2001


>  > > + /* Determine the length of concatenating an arbitrary number of
>  > > +    strings, up to (char *) NULL.  */
>  > > + 
>  > > + extern unsigned long concat_length PARAMS ((const char *, ...));
>  > 
>  > This should say "including" not "up to".
> 
> I don't think so, I copied that fragment from the comments above the
> original concat function.  The NULL in this case refers to the last
> argument to concat, not the trailing NULL terminator in any string.
> That last NULL argument is not copied, its a marker for the end of the
> variable argument list.

Ok, then it's obviously confusing ;-) How about "...strings.  You must
pass NULL as the last argument of this function, to terminate the list
of strings." ?  Although, if it the current text is the same as the
previous text, I won't stop the patch just because of that.

> The problem here is the fact that the concat functions have variable
> arguments.

Ick.  Ok, then.

I have no other comments.



More information about the Gcc-patches mailing list