Tree inlining for the C front end (part 1 of 3)
Alexandre Oliva
aoliva@redhat.com
Mon Oct 8 13:44:00 GMT 2001
On Oct 8, 2001, Richard Henderson <rth@redhat.com> wrote:
> On Sun, Oct 07, 2001 at 11:18:38PM -0300, Alexandre Oliva wrote:
>> +tree tree_inlining_default_hook_walk_subtrees (tp,subtrees,func,data,htab)
> Function name at beginning of line. All functions in
> langhooks.c suffer from this.
D'oh!
>> +struct lang_hooks_for_tree_inlining {
> struct lang_hooks_for_tree_inlining
> {
> ...
> };
Is the indentation you suggested correct? I knew (but forgot) about
the opening brace in a separate line, but GNU-style c-mode doesn't
indent it, and, after a bit of research, I couldn't find any struct
definition that had the `{' indented, but a number that had it
unindented, so I'm checking it in unindented.
>> + if (! (*lang_hooks.tree_inlining.auto_var_in_fn_p)(decl, fn))
> Space after function, before arguments.
For some reason, I thought this rule didn't apply to function calls
through pointers, when the pointer was dereferenced inside
parentheses. Hope I didn't make this mistake before.
> Otherwise ok.
Thanks, here's what I'm checking in. Tested with `make all' only,
given that there were only whitespace changes since the previous
patch, that was fully tested.
More information about the Gcc-patches
mailing list