Patch for warnings on various cross targets -- PA string handling breakage

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Fri Nov 30 15:11:00 GMT 2001


 > From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
 > 
 > > If this is indeed caused by me, sorry for the trouble I caused you.
 > > Would you please give me a target triplet?  I tried a cross-compile to
 > > hppa1.0-unknown-linux-gnu but it did the right thing when compiling
 > > the above code.
 > 
 > I have been trying to build a new set of tools on a couple of
 > hppa2.0w-hp-hpux11.X systems.  One is 11.00 and the other 11.11.
 > 
 > This is the fix.  It has passed bootstrap with enable-languages=c
 > and it fixes the problems I was having with gzip and openssl.  I am
 > now doing a full bootstrap and check.  If there are no regressions,
 > I will install.
 > 
 > Dave
 > 
 > 2001-11-30  John David Anglin  <dave@hiauly1.hia.nrc.ca>
 > 
 > 	* pa.c (output_ascii): Cast `p' to unsigned char.

Yes, privately I arrived at the exact same fix when I switched to an
hpux variant.

The reason I couldn't reproduce it initially is that pa-linux-gnu
doesn't uses pa.c:output_ascii.  Instead I think its macro
ASM_OUTPUT_ASCII has inline code which has subcalls to
ASM_OUTPUT_LIMITED_STRING from elfos.h.  Both of those macros had the
unsigned char issue dealt with correctly which masked the problem for
me.

Anyway, sorry for introducing the problem.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions



More information about the Gcc-patches mailing list