Patch for warnings on various cross targets -- PA string handling breakage

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Wed Nov 21 04:03:00 GMT 2001


 > From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
 > 
 > > Looking back at it, I concluded that most of this patch:
 > > 
 > > http://gcc.gnu.org/ml/gcc-patches/2001-10/msg01066.html
 > > 
 > > is really a whole bunch of obvious one-line changes.
 > 
 > > +2001-11-03  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
 > > +
 > ...
 > > +       * pa-protos.h (output_ascii): Use regular char *, not unsigned.
 > > +       * pa.c (output_ascii): Likewise.
 > 
 > I believe this patch has broken the handling of string constants on the
 > PA.  The following test program demonstrates the problem:
 > 
 > #define  GZIP_MAGIC     "\037\213"
 > extern int f (char *);
 > int g (void)
 > {
 >   return (f (GZIP_MAGIC));
 > }
 > 
 > The assembler output for GZIP_MAGIC is:
 > 
 >         .STRING "\x1f\xOb\x00"
 > 
 > The output for the second character should obviously be x8b.
 > Dave

If this is indeed caused by me, sorry for the trouble I caused you.
Would you please give me a target triplet?  I tried a cross-compile to
hppa1.0-unknown-linux-gnu but it did the right thing when compiling
the above code.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions



More information about the Gcc-patches mailing list