PowerPC SVR4 ABI compliance fix

Geoff Keating geoffk@geoffk.org
Tue Nov 13 19:20:00 GMT 2001


> Date: Fri, 23 Nov 2001 10:43:51 -0800
> From: Zack Weinberg <zack@codesourcery.com>
> Cc: Geoff Keating <geoffk@redhat.com>, gcc-patches@gcc.gnu.org,
>         Aldy Hernandez <aldyh@redhat.com>
> Content-Disposition: inline
> User-Agent: Mutt/1.3.23i
> 
> On Wed, Nov 21, 2001 at 11:23:08PM -0500, David Edelsohn wrote:
> > >>>>> Zack Weinberg writes:
> > 
> > >> Why do we need MASK_FOO and MASK_FOO_SET (MULTIPLE, STRING, and
> > >> AIX_STRUCT)?  
> > 
> > Zack> It's to detect whether the corresponding -m switches have been used
> > Zack> explicitly on the command line, but there must be a better way to do
> > Zack> that.
> > 
> > 	Yes, I've always disliked that waste of target_flags.  It seems to
> > be an artifact of the order in which GCC parses flags.  Maybe there is
> > some way to save a copy of the flags so that we can go back and inquire if
> > it originally was explicitly set by the user instead of setting multiple
> > target_flags.  I don't know if GCC provides a hook at the appropriate
> > place.  If it doesn't I would support adding one so that we can get rid of
> > this type of wastefulness.
> 
> In the mean time, would the patch be acceptable if I took out the -m
> switches?

I don't think the patch without the -m switches is really a good
idea; that would leave no way for users to be compatible with code
compiled earlier.

-- 
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>



More information about the Gcc-patches mailing list